[Bug 8129] New: quick slips issuing does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Priority: P5 - low Change sponsored?: --- Bug ID: 8129 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: quick slips issuing does not work Severity: normal Classification: Unclassified OS: All Reporter: leonardobareno@gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha in ./C4/Members.pm, IssueSlip function, $today string has "yyyy-mm-dd" format, but $it->{'issuedate'} and $it->{'due_date'} are in "yyyy-mm-ddThh:mm:ss" format, so the "eq" and "le" string comparisons made later are not going to work. suggested edition in ./C4/Members.pm: if ((substr $it->{'issuedate'}, 0, 10) eq $today) { $it->{'today'} = 1; } elsif ((substr $it->{'date_due'}, 0, 10) le $today) { $it->{'overdue'} = 1; } $it->{'date_due'}=format_date($it->{'date_due'}); } please accept my apologies for my lack of bugEtiquette. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 9844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9844&action=edit Bug 8129 - Quickslips not printing Implemented from the suggestions attached to the bug. To test: Check out a book to a patron Click print -> quick slip Slip should show only today's checkouts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall@gmail.com |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9848&action=edit Bug 8129 - Quickslips not printing Implemented from the suggestions attached to the bug. To test: Check out a book to a patron Click print -> quick slip Slip should show only today's checkouts. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9844|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9848|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9849&action=edit [SIGNED OFF] Bug 8129 - Quickslips not printing Implemented from the suggestions attached to the bug. To test: Check out a book to a patron Click print -> quick slip Slip should show only today's checkouts. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Blocks| |6430 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> --- Handles the date formatting with substrings... not the most general approach, but it works. Less load on the system than using DateTime to cast as a date. Updates variable name from "$today" to "$now", which is more general in our new hourly loan context. I'm in favour. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Bug fix, pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org