[Bug 7454] New: Sip renewal all response returns incorrect info
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7454 Bug #: 7454 Summary: Sip renewal all response returns incorrect info Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 AssignedTo: colin.campbell@ptfs-europe.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: ian.walls@bywatersolutions.com Testing by talkingtech to use the Koha sip interface for telephone renewals found that the response to a renew all request was returning more renewed items than the user actually had on loan. The usual workflow is for the client to send a patron info request to get a list of onloan items. The client can then send renewal requests individually or for all. Subsequent testing found that in a simple case after a couple of calls to renew_all for the same patron with one item on loan caused the response to list the same item twice, then three times, then four etc (on initial testing the number of items was wrong but as they came from another borrower it was not so clear that the list was just repeating from a previous session. Cause is that the data members used to return the list of item barcodes was not being cleared for the transaction and items could persist from a previous transaction -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7454 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7454 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2012-01-20 15:14:49 UTC --- Created attachment 7256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7256 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7454 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> 2012-01-20 15:17:30 UTC --- talkingtech and Staffordshire University have tested on their systems and the proposed patch corrects the system behaviour -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7454 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7256|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2012-02-19 06:51:09 UTC --- Created attachment 7750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7750 Bug 7454 Initialize return arrays in ILS/Transaction/RenewAll Explicitly clear these arrays and update them directly. In practice item numbers were already in them when called so that more items were being returned than were actually renewed (or failed) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Functionally sound patch, and tested in production -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7454 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7454 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-21 16:35:45 UTC --- QA comment: tiny patch, passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7454 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7454 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch will be included in the forthcoming 3.6.5 release (no string changes). -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org