[Bug 5373] New: fields listed on patron import do not match the csv file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Summary: fields listed on patron import do not match the csv file Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P5 Component: Tools AssignedTo: nengard@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 the fields listed in plain text on the patron import tool do not match those in the csv - the csv is correct, the text is wrong. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW AssignedTo|nengard@gmail.com |gmcharlt@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2010-11-07 22:16:37 UTC --- turns out this is not a simple template change it's a perl script that I don't understand (yet). Reassigning to the default assignee. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 --- Comment #2 from Garry Collum <gcollum@gmail.com> 2010-12-05 22:00:41 UTC --- Created attachment 2801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2801 Proposed Patch The two columns missing from the list that appear in the example CSV file are borrowernumber and cardnumber. The list is generated in import_borrowers.pl, but there is code that actually removes these two columns from the list. my $columnkeystpl = [ map { {'key' => $_} } grep {$_ ne 'borrowernumber' && $_ ne 'cardnumber'} @columnkeys ]; # ref. to array of hashrefs. This same list is used to create the form which is used to enter the default values on the Patron Import page. The proposed patch adds cardnumber to the template page and fixes the loop so that there is not a dangling comma at the end of the list. I did not add borrowernumber because it is an auto-incremented value in the borrower table. Adding a borrowernumber to a CSV file for import does nothing as far as I can tell. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2010-12-16 14:48:32 UTC --- Created attachment 2862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2862 signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-16 20:14:40 UTC --- Patch pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |--- --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-19 21:10:23 UTC --- Comment from Chris N "I was just doing a bit of cherry-picking for 3.2.x and noticed this patch which has been committed to HEAD. This is not the correct way to fix this "bug." Cardnumber is one of two fields stripped by line 64 in tools/import_borrowers.pl. If it is desirable to include 'cardnumber' in the field list, it should be removed from the grep in the underlying script at the above mentioned line. Doing this at the template level just results in an unnecessary remove and re-addition" I have reverted the patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 --- Comment #6 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-01-05 23:21:57 UTC --- This bug is mentioned in: Bug 5373: Adds cardnumber to the field list of the Import Patrons NOTES. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013191.... Bug 5373: Adds cardnumber to the field list of the Import Patrons NOTES. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013420.... Bug 5373: Adds cardnumber to the field list of the Import Patrons NOTES. http://lists.koha-community.org/pipermail/koha-patches/2010-December/013377.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 --- Comment #7 from Robin Sheat <robin@catalyst.net.nz> 2011-11-24 00:37:28 UTC --- Created attachment 6385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6385 Bug 5373 - allow 'cardnumber' to appear on the patron import field list For some reason, it was explicitly removed, however you need it if you want to match up on cardnumber. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2801|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2862|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-19 06:45:22 UTC --- Note: The online help file for the patron import page also lists borrowernumber: borrowernumber, cardnumber, surname, firstname... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6385|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-19 06:46:28 UTC --- Created attachment 7749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7749 [SIGNED-OFF] Bug 5373 - allow 'cardnumber' to appear on the patron import field list For some reason, it was explicitly removed, however you need it if you want to match up on cardnumber. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Easy to test and works nicely. Before patch cardnumber is not shown in the list of fields on the patron import page. After applying the patch it is. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-21 16:03:54 UTC --- QA comment: tiny patch, passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_6 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-21 16:06:21 UTC --- wow, git blame says: e3fa9f2d (Ryan Higgins 2008-08-09 15:27:27 -0500 65) my $columnkeystpl = [ map { {'key' => $_} } grep {$_ ne 'bor... was here for a very long time (3.5 years !!!) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch will be included in the forthcoming 3.6.5 release (no string changes). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org