https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32500 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32500 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32500 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144731|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 144846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144846&action=edit Bug 32500: Show only relevant message body option for OPAC_REG_VERIFY This patch changes the "Message body" options for the OPAC_REG_VERIFY notice so that only the relevant "borrower_modifications.verification_token" appears as an option. Tables like branches, biblio, biblioitems, items, borrowers, and issues aren't passed to OPAC_REG_VERIFY at processing time. The only table passed is "borrower_modifications", and only the token is the relevant field there. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32500 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #3)

Why not add_fields on borrower modifications? Maybe you want to change the notice and show some of the fields that have been entered? This seems too drastic?

Upon reviewing the borrower modifications table, I'm not sure why I thought verification_token should be the only field. It doesn't really make much sense. My concern about add_fields() is that it would have access to the "password" field. It looks like it's the hashed password rather than the clear text password, but it should probably be excluded. But it looks like we could modify the "get_columns_for" function in letter.pl to exclude that field. I'll have another think about this one another time! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32500 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Marcel de Rooy from comment #3)

Why not add_fields on borrower modifications? Maybe you want to change the notice and show some of the fields that have been entered? This seems too drastic?

Yeah, it might be too drastic after all. There should be fewer options but there should still be some more options than what I've provided here... -- You are receiving this mail because: You are watching all bug changes.