[Bug 33701] New: Catalogue detail page no longer shows all tab data when printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 Bug ID: 33701 Summary: Catalogue detail page no longer shows all tab data when printing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org Before the staff interface styling change, the data for the tabs "Holdings", "Descriptions", "Acquisition details", "Images", etc would be printed out vertically when printing the detail page. Now, when printing the detail page in the staff interface, it just shows the tab headings and the content/data for the active tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I'm attaching a patch which will work but there's more print CSS work to do on this page, and we might want to consider an alternative approach across the board. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 150819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150819&action=edit Bug 33701: Display all tab content when printing staff cat detail page This change adds some print CSS to display all tab content when printing the catalogue detail page on the staff interface. Test plan: 1. Apply patch 2. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 3. Click "Print" on the toolbar 4. Note that the "Descriptions" and "Acquisition details" also appear on the printed page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like the print layout was much better in the old design, something that slipped through unnoticed so far. For example navigation items and sidebar should be hidden. But this really feels like it should be fixed globally for printing tabs instead of only for the staff detail view. Another example is printing the patron account details/checkouts pages, holds awaiting pick-up etc. Is there a way the headings could be displayed above each content section? (asking, not blocker) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #3)
It looks like the print layout was much better in the old design, something that slipped through unnoticed so far. For example navigation items and sidebar should be hidden.
Yeah I was thinking the same thing. The old print layout was quite nice really. I can see why it slipped past though. I don't know why people print webpages...
But this really feels like it should be fixed globally for printing tabs instead of only for the staff detail view.
Agreed. I'm not familiar enough with the whole design to know how to do it. But happy to help someone who does.
Another example is printing the patron account details/checkouts pages, holds awaiting pick-up etc.
I think we might need to define a class like "print-visible" and then apply it to each tab panel on each page individually. I think the same classes are used for all the tabs at the moment, which makes it tough to isolate certain parts of the page. But hopefully a person more focused on the frontend UI can weigh in on that one..
Is there a way the headings could be displayed above each content section? (asking, not blocker)
Not that I know of since the HTML for the tab headings and tab contents are in different spots, but someone else might have an idea for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- For now, I'm just going to work around this using the syspref IntranetUserCSS: @media print { /* print-visible */ #bibliodetails .tab-pane { display: block !important; height: auto !important; visibility: visible !important; overflow: visible !important; } } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33701 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Still an issue -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org