[Bug 36983] New: B_address_2 field is required even when not set to be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Bug ID: 36983 Summary: B_address_2 field is required even when not set to be required Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org In the self registration form the B_address2 field has the required class incorrectly set to match that of the B_address field and so acts as required even when not set to be required in PatronSelfRegistrationBorrowerMandatoryField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167238&action=edit Bug 36983: Fix incorrect required class This patch fixes an error on the B_address2 field which sets it to be required incorrectly Test plan: 1) In PatronSelfRegistrationBorrowerMandatoryField, set B_address to be required. 2) In the OPAC, navigate to the self registration form. 3) In the Alternate address section, fill in the Address field that you have just set to be required. Ensure that you leave the Address 2 field blank. 4) Fill in all other required fields and submit the form, it should show you that the Address 2 field is required, even though it shouldn't be 5) Apply patch 6) Refresh the page and repeat steps 1-5, it should allow youto submit the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167238|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167240&action=edit Bug 36983: Fix incorrect required class This patch fixes an error on the B_address2 field which sets it to be required incorrectly Test plan: 1) In PatronSelfRegistrationBorrowerMandatoryField, set B_address to be required. 2) In the OPAC, navigate to the self registration form. 3) In the Alternate address section, fill in the Address field that you have just set to be required. Ensure that you leave the Address 2 field blank. 4) Fill in all other required fields and submit the form, it should show you that the Address 2 field is required, even though it shouldn't be 5) Apply patch 6) Refresh the page and repeat steps 1-5, it should allow youto submit the form Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167240|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 167566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167566&action=edit Bug 36983: Fix incorrect required class This patch fixes an error on the B_address2 field which sets it to be required incorrectly Test plan: 1) In PatronSelfRegistrationBorrowerMandatoryField, set B_address to be required. 2) In the OPAC, navigate to the self registration form. 3) In the Alternate address section, fill in the Address field that you have just set to be required. Ensure that you leave the Address 2 field blank. 4) Fill in all other required fields and submit the form, it should show you that the Address 2 field is required, even though it shouldn't be 5) Apply patch 6) Refresh the page and repeat steps 1-5, it should allow youto submit the form Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Severity|enhancement |normal Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from wainuiwitikapark@catalyst.net.nz --- not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the patron self release notes| |registration form. If the | |address field (B_address) | |in the alternative address | |section was set to required | |using the | |PatronSelfRegistrationBorro | |werMandatoryField system | |preference, it was | |incorrectly making the | |address 2 field | |(B_address2) required on | |the form as well (even | |though it was not selected | |in the system preference). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36983 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org