[Bug 9803] New: question mark in cataloging not clearly a link
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 Bug ID: 9803 Summary: question mark in cataloging not clearly a link Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com When you mouse over the question mark to the right of marc fields in cataloging it's not clear that it's a link because the usual cursor don't show up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16554&action=edit Bug 9803 - question mark in cataloging not clearly a link When you hover your mouse over the MARC tag help link in cataloging the cursor doesn't change to a standard link pointer because the <a> tag has no "href" attribute. This patch adds a dummy href, "#" so that the cursor will treat it as a link. To test, apply the patch and load the MARC editor with a blank or existing record. The "Show MARC tag documentation links" checkbox must be checked. Hover your mouse over a "?" link in any tag. The cursor should change to a pointer like it does on other links. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16554|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 16555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16555&action=edit Bug 9803 - question mark in cataloging not clearly a link When you hover your mouse over the MARC tag help link in cataloging the cursor doesn't change to a standard link pointer because the <a> tag has no "href" attribute. This patch adds a dummy href, "#" so that the cursor will treat it as a link. To test, apply the patch and load the MARC editor with a blank or existing record. The "Show MARC tag documentation links" checkbox must be checked. Hover your mouse over a "?" link in any tag. The cursor should change to a pointer like it does on other links. Signoff comment: The patch works as expected. Besides the cursor change, links still work on every tab. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Simple patch. It changes the cursor for help links on cataloguing. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16555|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16977&action=edit Bug 9803 - question mark in cataloging not clearly a link When you hover your mouse over the MARC tag help link in cataloging the cursor doesn't change to a standard link pointer because the <a> tag has no "href" attribute. This patch adds a dummy href, "#" so that the cursor will treat it as a link. To test, apply the patch and load the MARC editor with a blank or existing record. The "Show MARC tag documentation links" checkbox must be checked. Hover your mouse over a "?" link in any tag. The cursor should change to a pointer like it does on other links. Signoff comment: The patch works as expected. Besides the cursor change, links still work on every tab. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9366 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9803 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org