[Bug 9797] New: Untranslatable strings have returned to ajax.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 Bug ID: 9797 Summary: Untranslatable strings have returned to ajax.js Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org CC: frederic@tamil.fr The patch for Bug 8942 undid the changes to ajax.js made by Bug 9331. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16055&action=edit Bug 9797 - Untranslatable strings have returned to ajax.js The patch for Bug 8942 undid the changes to ajax.js made by Bug 9331. This patch puts those changes back. To test that preference-related error messages continue to work, open the system preferences editor in two tabs. Log out in one tab and try to save a system preference in the other. You should see correct error messages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 --- Comment #2 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 16275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16275&action=edit snapshot without patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 16278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16278&action=edit snapshot with patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com --- Comment #4 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hello Owen, sry but I need clarification, I join 2 snapshots, without the patch and with it. I see no differences, but probably I don't look at the right place. Could you precise the test plan ? Thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Thanks for testing, The fact that you see no differences is a good sign the patch is working. The only way to test that the patch fixes translations is to update your translation and confirm that the string is now in the po file. For instance: Before the patch, searching misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po for the string "Error; your data might not have been saved" will return no results. After running "perl translate update fr-FR" from misc/translator another search should return one result for the same search. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 --- Comment #6 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hello Owen, thx, unfortunately after the translate I have not the string in fr-FR-i-staff-t-prog-v-3006000.po. But we have two warnings during the translation (not due to your patch), I don't think it is related : Warning: Can't determine original templates' charset, defaulting to UTF-8 Warning: Charset Out defaulting to UTF-8 /home/christophe/workspace/versions/community/misc/translator/po/fr-FR-opac-ccsr.po: Aucun fichier ou dossier de ce type The first warning with utf8 by default I think it is ok, and the second one is about opac, so these warnings I think, are related with the fact that the translation doesn't insert the string expected. Maybe you have an idea about that. Thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #6)
Hello Owen, thx, unfortunately after the translate I have not the string in fr-FR-i-staff-t-prog-v-3006000.po. But we have two warnings during the translation (not due to your patch)
I get the same errors when I run "perl translate update fr-FR" (as I do in master), but I still see the new strings successfully added to the po file. Can you test again? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16747&action=edit Bug 9797 - Follow up : use double quotes in javascript translatable strings Followup to correct a translation bug, see Bug 8942 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16055|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #9 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16752&action=edit [SIGNED-OFF] Bug 9797 - Untranslatable strings have returned to ajax.js Patch signed off by Pierre Angot -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16747|0 |1 is obsolete| | --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16753&action=edit [SIGNED-OFF] Bug 9797 - Follow up : use double quotes in javascript translatable strings Patch signed off by Pierre Angot -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |String patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: These patches reintroduce changes made in bug 8942. Strings appears in po file. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16752|0 |1 is obsolete| | Attachment #16753|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16990&action=edit Bug 9797 - Untranslatable strings have returned to ajax.js The patch for Bug 8942 undid the changes to ajax.js made by Bug 9331. This patch puts those changes back. To test that preference-related error messages continue to work, open the system preferences editor in two tabs. Log out in one tab and try to save a system preference in the other. You should see correct error messages. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16991&action=edit Bug 9797 - Follow up : use double quotes in javascript translatable strings Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9797 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org