[Bug 26018] New: Not all subfields for the following tags are in the same tab (or marked 'ignored')
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Bug ID: 26018 Summary: Not all subfields for the following tags are in the same tab (or marked 'ignored') Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: psmukhopadhyay@gmail.com QA Contact: testopia@bugs.koha-community.org In a fresh install of Koha 20.05.01.000 the 'MARC bibliographic framework test' fails in one point reporting that "Not all subfields for the following tags are in the same tab (or marked 'ignored')" for all preloaded formats (Default to VR). In every case invariably the culprit is subfield 2 of the below mentioned tags - 240(1,2) | 700 (1,7) | 710 (1,7) | 711 (1,7) | 730 (1,7) | 758 (1,7) | 800 (1,8) | 810 (1,8) | 811 (1,8) | 830 (1,8). The numbers within parenthesis indicate tabs are in use. It only occurs in case of a fresh installation of 20.05.01 loaded with default formats (Default, AR, BKS, CF, IR, KT, SER, SR, VR), not with the upgradations of 18.x or 19.x to 20.05.01 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, which language did you choose - English? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 --- Comment #2 from PS Mukhopadhyay <psmukhopadhyay@gmail.com> --- Yes, English. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 107054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107054&action=edit Bug 26018: Fix frameworks errors with subfields in wrong tab All subfields for a MARC21 field should always be in the same tab. There were some mistakes found by the "MARC bibliographic framework test" this fixes. Before you apply the patch: - Check the "MARC bibliographic framework test" page - Ideally you should see the "wrong tab" mistakes - Reset your db (reset_all) or drop your db and run the web installer - Verify the page no longer points out any issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107054|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110221&action=edit Bug 26018: Fix frameworks errors with subfields in wrong tab All subfields for a MARC21 field should always be in the same tab. There were some mistakes found by the "MARC bibliographic framework test" this fixes. Before you apply the patch: - Check the "MARC bibliographic framework test" page - Ideally you should see the "wrong tab" mistakes - Reset your db (reset_all) or drop your db and run the web installer - Verify the page no longer points out any issues Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent, works as expected.. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110221|0 |1 is obsolete| | --- Comment #6 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 111536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111536&action=edit Bug 26018: Fix frameworks errors with subfields in wrong tab All subfields for a MARC21 field should always be in the same tab. There were some mistakes found by the "MARC bibliographic framework test" this fixes. Before you apply the patch: - Check the "MARC bibliographic framework test" page - Ideally you should see the "wrong tab" mistakes - Reset your db (reset_all) or drop your db and run the web installer - Verify the page no longer points out any issues Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to PS Mukhopadhyay from comment #0)
It only occurs in case of a fresh installation of 20.05.01 loaded with default formats (Default, AR, BKS, CF, IR, KT, SER, SR, VR), not with the upgradations of 18.x or 19.x to 20.05.01
Which means it's a regression, so I thought about bug 24594. However, I have checked for 240$2 and it was in tab 1 already: ('240', '2', 'Source of heading or term', 'Source of heading or term', 0, 0, '', 1, '', '', '', NULL, -6, '', '', '', NULL), Should we fix existing installations? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have thought about it, but it's probably not so easy. For custom frameworks people might have moved fields to different tabs intentionally (think FA framework), the problem is that they should not split subfields on different tabs. So if we find a case where people have a on tab 1 and b on tab 2 ... how would we clean that up? We have the test in the GUI, maybe we should put a reminder on release notes that people should check it and fix errors pointed out? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Herbert Janes <hgjanes@comcast.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hgjanes@comcast.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 --- Comment #11 from Herbert Janes <hgjanes@comcast.net> --- I have found this bug in a fresh install of 19.11.11.000. Is the fix the same? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26018 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Herbert Janes from comment #11)
I have found this bug in a fresh install of 19.11.11.000. Is the fix the same?
Yes, can confirm this bug exists in 19.11.x, however the fix is not the same. This can't be backported to 19.11.x. Please rebase for 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org