[Bug 25167] New: Fix to a fix wrong inventory results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Bug ID: 25167 Summary: Fix to a fix wrong inventory results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org Hi, Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 solves the case when notforloan filter is not used, but it breaks the case when a filter is used. Regards Didier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12913 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi didier, when adding a new bug and you know where the problem comes from or which bug it's related to, you can use the "depends on" and "see also" to add a link. This will also make sure people on the other bug get an email :) Also the Importance preselects to enhancement - important to switch for bugs! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12913 [Bug 12913] Fix wrong inventory results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix to a fix wrong |Fix not for loan filter in |inventory results |inventory tool --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you detail how the bheaviour is broken? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #3 from didier <didier.gautheron@biblibre.com> --- Created attachment 105374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105374&action=edit Bug 25167: Fix to a fix wrong inventory results Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25608 Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |didier.gautheron@biblibre.c |ity.org |om Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 [Bug 25608] Regression: Bug 23463 broke inventory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am looking at the code, but not understanding it well enough to see if this is the right fix. I wonder why we need no extra treatment for the other available checkbox options (withdrawn, lost and damaged). Leaving this for someone more familiar with inventory code in the QA team. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #5 from didier <didier.gautheron@biblibre.com> --- Hi, Other available checkbox options (withdrawn, lost and damaged) weren't in the list in the original functionality. This patch only restore the previous behaviour, at least I hope so. On the other hand not testing withdrawn, lost and so on doesn't seem to make sense. Regards Didier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105374|0 |1 is obsolete| | --- Comment #6 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112262&action=edit Bug 25167: Fix to a fix wrong inventory results Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- Behavior seems correct, now we have a warning on scanned barcode with a notforloan different from the one checked (on master, we just have a warning on the not scanned items). CSV export works fine. For what I saw, warning are still broken for the other 3 status Katrin mentioned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112353&action=edit Bug 25167: (QA follow-up) Don't add a new variable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- This fixes the issue mentioned, others should be on a new bug, there could be a lot of refactoring here to make this a bit more readable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Missing QA stamp. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nick, can you fix your QA please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112262|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112833&action=edit Bug 25167: Fix to a fix wrong inventory results Test plan : - Check you have in default framework an item subfield mapped with items.notforloan and with an authorized value catergory, for example 'NOTFORLOAN' - Create a new value in this category, for example '9' - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='A-1' and notforloan=0 - Create an item with barcode='000AAA2', callnumber='A-2' and notforloan=9 - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'A-0' and 'A-9' - Check 'Compare barcodes list to results' - Submit=> without patch, you get no warnings - Redo the same inventory but with checking items.notforloan 'For loan' (using the browser back page is ok) - submit => still no warning, Bug 000AAA2 must be listed it's not 'For loan' - Apply patch, repeat, with tems.notforloan 'For loan' checked you get the right warning Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112353|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112834&action=edit Bug 25167: (QA follow-up) Don't add a new variable Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25167 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org