[Bug 26900] New: Fixes Koka::Libraries typo in C4/Reserves.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Bug ID: 26900 Summary: Fixes Koka::Libraries typo in C4/Reserves.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Plain simple: my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} ); This patch replaces 'Koka' by 'Koha'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Created attachment 112864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112864&action=edit Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm Plain simple: my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} ); This patch replaces 'Koka' by 'Koha'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |philippe.blouin@inlibro.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #2 from Blou <philippe.blouin@inlibro.com> --- this is also in 20.05, and I suppose 20.11. I'm checking and rechecking if I'm crazy. This would not have triggered for anybody else in 18 months?! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #3 from Blou <philippe.blouin@inlibro.com> --- well, my maths suck. I guess I'm too used to work on 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112864|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 112870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112870&action=edit Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm Plain simple: my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} ); This patch replaces 'Koka' by 'Koha'. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112870|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112880&action=edit Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm Plain simple: my $home_library = Koka::Libraries->find( {branchcode => $item->homebranch} ); This patch replaces 'Koka' by 'Koha'. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is it possible that the if ($pickup_library) {} is dead code? The only time we seem to be using the parameter is in a test in t/db_dependent/Reserves.t. Or... should we have been using it somewhere? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #7 from Blou <philippe.blouin@inlibro.com> --- Not exactly sure, but this occurred in the opening sequences of our testing of 20.05.05 - Default database - No modification of preferences - add a rule to allow all to put on reserve. - add one record with one item using "book" as itemtype - Search for it in the OPAC - click on Hold, select a library, save, boom! So this was through the UI, and I *presume* of normal usage by our librarian who gave me the steps to reproduce. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22284 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit a998ba5714c8dc1b78062e95bd78e2738112737d Bug 22284: Control hold groups in C4::Reserves Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Add ability to define groups of locations for hold pickup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26900 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org