[Bug 42175] New: Running under Mojo is broken in k.t.d
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 Bug ID: 42175 Summary: Running under Mojo is broken in k.t.d Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jake.deery@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org When running Koha as a Mojo app under k.t.d, nothing loads. This is, in my assessment, because we're not using absolute paths when calling for each web script. I will post a patch shortly, showing my workings. It would be appreciated if we could get a quick SO / QA for this as it'll be necessary for a coming k.t.d patch. A beer is offered as thanks! Ta, Jake -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jake.deery@openfifth.co.uk |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 --- Comment #1 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 196147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196147&action=edit Bug 42175: Fix Mojo under k.t.d This patch fixes Mojo under k.t.d by providing CGI::Compile with an absolute rather than relative path. TO TEST: == APPLY PATCH == a) run reset_all b) run apachectl stop c) run /kohadevbox/koha/bin/opac prefork -m production -p -l http://*:8080 c) run /kohadevbox/koha/bin/intranet prefork -m production -p -l http://*:8081 d) confirm you can use k.t.d as normal == SIGN OFF == -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196147|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 --- Comment #2 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 196590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196590&action=edit Bug 42175: Fix Mojo under k.t.d This patch fixes Mojo under k.t.d by providing CGI::Compile with an absolute rather than relative path. TO TEST: == APPLY PATCH == a) run reset_all b) run apachectl stop (if apache does not stop, may need to `sudo kill -9 apache2`) c) run /kohadevbox/koha/bin/opac prefork -m production -p -l http://*:8080 & c) run /kohadevbox/koha/bin/intranet prefork -m production -p -l http://*:8081 & d) confirm you can use k.t.d. as normal == SIGN OFF == Signed-off-by: Eric Phetteplace <ephetteplace@cca.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ephetteplace@cca.edu --- Comment #3 from Eric Phetteplace <ephetteplace@cca.edu> --- Apache didn't die when I followed these steps and I changed the steps to run the staff/public sides in the background so you don't need two shells. I don't know anything about Mojo but this appeared to work for me as I smoke tested Koha afterwards. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- So... I don't really understand this one. I tried the following: Test plan: - Do NOT apply the patch - run reset_all - sudo koha-plack --stop kohadev - sudo service apache2 stop - run /kohadevbox/koha/bin/opac prefork -m production -p -l http://*:8080 - run /kohadevbox/koha/bin/intranet prefork -m production -p -l http://*:8081 - confirm you can use k.t.d as normal I didn't need the patch? No problems accessing http://localhost:8080/cgi-bin/koha/opac-main.pl and http://localhost:8081/cgi-bin/koha/mainpage.pl (That said, I can't get http://localhost:8081/cgi-bin/koha/tools/upload-cover-image.pl to work when running it this way) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 [Bug 20582] Turn Koha into a Mojolicious application -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Ah wait I understand. You were missing a critical step in your test plan. You need to make sure you're running those commands outside of the "koha" directory. They work when you run them in "koha" because of the relative paths. Yep yep yep. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196590|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Created attachment 196601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196601&action=edit Bug 42175: Fix Mojo under k.t.d This patch fixes Mojo under k.t.d by providing CGI::Compile with an absolute rather than relative path. TO TEST: == APPLY PATCH == a) run reset_all b) run apachectl stop (if apache does not stop, may need to `sudo kill -9 apache2`) c) run /kohadevbox/koha/bin/opac prefork -m production -p -l http://*:8080 & c) run /kohadevbox/koha/bin/intranet prefork -m production -p -l http://*:8081 & d) confirm you can use k.t.d. as normal == SIGN OFF == Signed-off-by: Eric Phetteplace <ephetteplace@cca.edu> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Simple change which makes sense. Could backport this all the way back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42228 [Bug 42228] Add config files for Hypnotoad -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42175 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org