[Bug 42134] New: String displays incorrectly: words “notices” and “for” appear concatenated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Bug ID: 42134 Summary: String displays incorrectly: words “notices” and “for” appear concatenated Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: anneli.osterman@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org Description: When viewing a notice in the Notices and slips page -> Format tab there is a text `Apply format settings to all noticesfor this language:` The rendered text on the staff interface shows the words *“notices”* and *“for”* stuck together without a space. This occurs on the following translation entry: https://translate.koha-community.org/translate/koha/main/staff-prog/fi/?chec... Apply format settings to all notices%sfor this language%s: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:827 Steps to reproduce: 1. Open the staff interface and navigate to Tools -> Notices and slips -> Open one of the notices -> Go to the Format tab. 2. Navigate to the section where the above string is displayed. 3. Observe that the rendered text lacks a space between “notices” and “for”. Expected behavior: A space should appear between the words, e.g.: `Apply format settings to all notices for this language:` Actual behavior: The words appear concatenated: `noticesfor` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 195826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195826&action=edit Bug 42134: String displays incorrectly: words ânoticesâ and âforâ appear concatenated This patch changes the way the notices template checks for the existence of the TranslateNotices system preference in order to avoid a missing space in the corresponding label. To test you should have at least two languages enabled under the StaffInterfaceLanguages system preference. - Apply the patch and go to Administration -> System preferences.. - Locate the TranslateNotices preference and set it to "Allow" - Go to Tools -> Notices and edit a notice. - The "Modify notice" page should have tabs each of your enabled languages as well as "Default." - Each tab should have a "Format" section. Expand it and check that the label for the checkbox at the bottom is correct, e.g. "Apply format settings to all notices for this language." - Return to system preferences and set TranslateNotices to "Don't allow." - Reload the notice edit screen and check the "Format" section. The label should now read "Apply format settings to all notices." Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195826|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 196181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196181&action=edit Bug 42134: String displays incorrectly: words ânoticesâ and âforâ appear concatenated This patch changes the way the notices template checks for the existence of the TranslateNotices system preference in order to avoid a missing space in the corresponding label. To test you should have at least two languages enabled under the StaffInterfaceLanguages system preference. - Apply the patch and go to Administration -> System preferences.. - Locate the TranslateNotices preference and set it to "Allow" - Go to Tools -> Notices and edit a notice. - The "Modify notice" page should have tabs each of your enabled languages as well as "Default." - Each tab should have a "Format" section. Expand it and check that the label for the checkbox at the bottom is correct, e.g. "Apply format settings to all notices for this language." - Return to system preferences and set TranslateNotices to "Don't allow." - Reload the notice edit screen and check the "Format" section. The label should now read "Apply format settings to all notices." Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196217&action=edit Bug 42134: String displays incorrectly: words ânoticesâ and âforâ appear concatenated This patch changes the way the notices template checks for the existence of the TranslateNotices system preference in order to avoid a missing space in the corresponding label. To test you should have at least two languages enabled under the StaffInterfaceLanguages system preference. - Apply the patch and go to Administration -> System preferences.. - Locate the TranslateNotices preference and set it to "Allow" - Go to Tools -> Notices and edit a notice. - The "Modify notice" page should have tabs each of your enabled languages as well as "Default." - Each tab should have a "Format" section. Expand it and check that the label for the checkbox at the bottom is correct, e.g. "Apply format settings to all notices for this language." - Return to system preferences and set TranslateNotices to "Don't allow." - Reload the notice edit screen and check the "Format" section. The label should now read "Apply format settings to all notices." Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42134 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org