[Bug 37910] New: Minor spacing issues in the catalog concerns page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Bug ID: 37910 Summary: Minor spacing issues in the catalog concerns page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org There are some spaces missing in the catalog concerns table. To get there: 1. Enable the CatalogConcerns system preference 2. Search for a bibliographic record and access its details page 3. Click New > New catalog concern 4. Enter a title (an optionally a description) 5. Click Submit 6. Click the Concerns tab 7. Click the Details button next to the concern 8. Write an update 9. Search for and choose a patron in the Change assignee field 10. Click Update --> In the table in the record details page, there is no space between the status (Open) and the Assigned to string 11. Go to Cataloging > Catalog concerns --> Same problem as above --> There is also no space between the title of the ticket and the speech bubble indicating there has been an update (this is ok in the record details page) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I also noticed there are spaces missing when viewing the updated ticket. - Between the assignee's name and the description (I feel like those two things should not be on the same line?) - Between the "Private" and the text of the update - Between the date of the update and the assignee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I found another one. If you resolve the concern, and show the resolved concerns in the table, there is no space between the name/link of the staff and the date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, | |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37912 [Bug 37912] Catalog concerns - Broken link under concern title -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173650&action=edit Bug 37910: Update concerns styling to flexbox With the update to bootstrap 5 we loose some of the absolute and relative positioning helpers, namely pull-right, which were used in the catalog concerns pages. This patch updates the table and modal styling to use modern flexbox utlities from bootstrap 5 instead to improve the styling and fix the regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173651&action=edit 24.05 Modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- The content of attachment 173651 has been deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173652&action=edit Modal using flex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173653&action=edit 24.05 Modal (before bootstrap 5) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173659&action=edit Bug 37910: Minor improvements to comment form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173660&action=edit Bug 37910: Sync fixes to detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173660|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173661&action=edit Bug 37910: Sync fixes to detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #11 from David Nind <david@davidnind.com> --- This fixes all the issues Caroline identified. However, there is one new thing that I noted: 1. On the details page for a record > Concerns > Details column: . Before the patch: the title and number of comments/updates are a link (I think it is just one link): clicking either of these opens the details view for the catalog concern (as expected) . After the patch: the details view doesn't open 2. On the catalog concerns listing (Cataloging > Catalog concerns): . Before the patch: the title and number of comments/updates are separate links - clicking on them doesn't open the details view . After the patch: same behavour as before the patch, no details view opens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #11)
This fixes all the issues Caroline identified.
However, there is one new thing that I noted:
1. On the details page for a record > Concerns > Details column: . Before the patch: the title and number of comments/updates are a link (I think it is just one link): clicking either of these opens the details view for the catalog concern (as expected) . After the patch: the details view doesn't open
2. On the catalog concerns listing (Cataloging > Catalog concerns): . Before the patch: the title and number of comments/updates are separate links - clicking on them doesn't open the details view . After the patch: same behavour as before the patch, no details view opens
This is fixed by bug 37912. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173650|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 173692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173692&action=edit Bug 37910: Update concerns styling to flexbox With the update to bootstrap 5 we loose some of the absolute and relative positioning helpers, namely pull-right, which were used in the catalog concerns pages. This patch updates the table and modal styling to use modern flexbox utlities from bootstrap 5 instead to improve the styling and fix the regressions. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173659|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 173693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173693&action=edit Bug 37910: Minor improvements to comment form Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173661|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 173694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173694&action=edit Bug 37910: Sync fixes to detail page Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173692|0 |1 is obsolete| | --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 174056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174056&action=edit Bug 37910: Update concerns styling to flexbox With the update to bootstrap 5 we loose some of the absolute and relative positioning helpers, namely pull-right, which were used in the catalog concerns pages. This patch updates the table and modal styling to use modern flexbox utlities from bootstrap 5 instead to improve the styling and fix the regressions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173693|0 |1 is obsolete| | --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 174057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174057&action=edit Bug 37910: Minor improvements to comment form Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173694|0 |1 is obsolete| | --- Comment #18 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 174058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174058&action=edit Bug 37910: Sync fixes to detail page Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz QA Contact|testopia@bugs.koha-communit |aleisha@catalyst.net.nz |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have a small conflict here I am not sure about - can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #19)
I have a small conflict here I am not sure about - can you please rebase?
I think this might have slipped through. As this is a bug fix, I don't need to extend deadlines now, but would prefer to have it before Wednesday. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not for 24.11.00. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174056|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174703&action=edit Bug 37910: Update concerns styling to flexbox With the update to bootstrap 5 we loose some of the absolute and relative positioning helpers, namely pull-right, which were used in the catalog concerns pages. This patch updates the table and modal styling to use modern flexbox utlities from bootstrap 5 instead to improve the styling and fix the regressions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174057|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174704&action=edit Bug 37910: Minor improvements to comment form Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174058|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174705&action=edit Bug 37910: Sync fixes to detail page Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Just a rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37910 Bug 37910 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org