http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 12947 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31685&action=edit Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working I introduced this bug with my patch for Bug 8181. In changing the way the date picker widgets worked I changed the ID the "clear date" javascript was looking for, so it stopped working. This patch corrects it and improves the JavaScript by moving it out of the HTML markup. This patch also makes some minor HTML validity corrections: escaping ampersands and removing a "size" attribute from a hidden form field. To test, you should have the AllowHoldDateInFuture system preference enabled. Place a hold in the staff client for a patron and confirm that you can choose a "hold starts on" date and a "hold expires on" date and that the respective "clear date" links work correctly for each one. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31685|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31996&action=edit [SIGNED OFF] Bug 12893 - 'Clear date' links on start and expiration hold date in staff not working I introduced this bug with my patch for Bug 8181. In changing the way the date picker widgets worked I changed the ID the "clear date" javascript was looking for, so it stopped working. This patch corrects it and improves the JavaScript by moving it out of the HTML markup. This patch also makes some minor HTML validity corrections: escaping ampersands and removing a "size" attribute from a hidden form field. To test, you should have the AllowHoldDateInFuture system preference enabled. Place a hold in the staff client for a patron and confirm that you can choose a "hold starts on" date and a "hold expires on" date and that the respective "clear date" links work correctly for each one. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12893 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.