http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 24113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24113&action=edit Bug 11515 - Encoding problem with OpacBrowseResults When OpacBrowseResults syspref is on, the detail page contains a results browser. When search terms contains non-ASCII character, the search query is not well encoded in this browser. This patch adds the URI-coding to search terms into session to avoid any encoding problem with diacritics and URI specific characters like ?,& ... So that TT parameter 'busc' is already URI encoded and can be used to recreate seach URL. Test plan : - Set OpacBrowseResults on - At OPAC, perform a search with a diacritique. For example 'déjà' - Go to detail page of a result => You see browser under "Browser results" - Click on "Back to results" => You get same results and same search term with correct encoding -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515

--- Comment #3 from Fridolin SOMERS <fridolyn.somers@biblibre.com> ---
(In reply to Petter Goksøyr Åsen from comment #2)
> I don't experience this encoding issue, using queries with Norwegian
> characters or French diactric marks. The query is always correctly
> displayed. It's also displayed correctly after I apply the patch..
Odd.
When I test on master :
- simple search at OPAC with "centré"
- I have 5 results
- I click on a result
- I click on "Back to results"
=> I get the page : "cgi-bin/koha/opac-search.pl?idx=&q=centré", "centré" in
search box and no results.

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Petter Goksøyr Åsen from comment #4)

It seems to me that it is not dealt with properly once and for all in Koha (ie. force utf-8 everywhere), but instead patched here and there, with the result that we sometimes get double-encoding issues. However, I do not know enough about Perl or Koha yet, so I might be totally wrong

Well, this sounds (unfortunately) quite correct to me :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> ---

I've tested with "øl". It works. I mean this patch is not needed for "øl".

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Without patch, when searching "centré", I get in "Back to results" : opac-search.pl?idx=&q=centr%C3%83%C2%A9 My locale is "fr-FR.UTF-8". Seems this bug exists only since 3.14. Can you test on a fresh install ? -- You are receiving this mail because: You are watching all bug changes.

...

Seems this bug exists only since 3.14. Can you test on a fresh install ?

By fresh install, do you mean the debian package? And not from git master? No, I mean an install created from scratch, not an existing install with

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 --- Comment #11 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Petter Goksøyr Åsen from comment #10) sources updated to current master. If someone else could test, it would be great. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24113|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fridolin, could you check this is still valid on current master? Also... patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26023|0 |1 is obsolete| | --- Comment #15 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 32063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32063&action=edit Bug 11515 - Encoding problem with OpacBrowseResults When OpacBrowseResults syspref is on, the detail page contains a results browser. When search terms contains non-ASCII character, the search query is not well encoded in this browser. This patch adds the URI-coding to search terms into session to avoid any encoding problem with diacritics and URI specific characters like ?,& ... So that TT parameter 'busc' is already URI encoded and can be used to recreate seach URL. Test plan : - Set OpacBrowseResults on - At OPAC, perform a search with a diacritique. For example 'déjà' - Go to detail page of a result => You see browser under "Browser results" - Click on "Back to results" => You get same results and same search term with correct encoding -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32063|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33084&action=edit Bug 11515 - Encoding problem with OpacBrowseResults -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Works well. I do wonder if this is the level to solve this at, but it works! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.