https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 99291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99291&action=edit Bug 24688: Check the priority of the fulfilled hold when fixing priorities Currently when fixing priorities of existing holds, priorities aren't fixed when checking out a middle priority hold because the hold has been fulfilled and deleted. This patch adds a check for, if the hold can't be found, an old hold with the required reserve_id. To test: 1. Place at least four holds on a biblio for different borrowers 2. Check out an item to the 3rd priority borrower 3. Check the existing holds table for the biblio. The priorities might be out of order, or try clicking the dropdowns and there might be an empty dropdown option, or open the browser developer tools and notice the option values in the select are missing value=3. 4. Apply patch and restart memcached 5. Check out an item to the 2nd priority borrower 6. Check the existing holds table for the biblio. Confirm the priorities have been fixed and are now consecutive with no gaps. Sponsored-by: Chartered Accountants Australia and New Zealand -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99291|0 |1 is obsolete| | --- Comment #2 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 100435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100435&action=edit Bug 24688: Check the priority of the fulfilled hold when fixing priorities Currently when fixing priorities of existing holds, priorities aren't fixed when checking out a middle priority hold because the hold has been fulfilled and deleted. This patch adds a check for, if the hold can't be found, an old hold with the required reserve_id. To test: 1. Place at least four holds on a biblio for different borrowers 2. Check out an item to the 3rd priority borrower 3. Check the existing holds table for the biblio. The priorities might be out of order, or try clicking the dropdowns and there might be an empty dropdown option, or open the browser developer tools and notice the option values in the select are missing value=3. 4. Apply patch and restart memcached 5. Check out an item to the 2nd priority borrower 6. Check the existing holds table for the biblio. Confirm the priorities have been fixed and are now consecutive with no gaps. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100435|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 101117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101117&action=edit Bug 24688: Check the priority of the fulfilled hold when fixing priorities Currently when fixing priorities of existing holds, priorities aren't fixed when checking out a middle priority hold because the hold has been fulfilled and deleted. This patch adds a check for, if the hold can't be found, an old hold with the required reserve_id. To test: 1. Place at least four holds on a biblio for different borrowers 2. Check out an item to the 3rd priority borrower 3. Check the existing holds table for the biblio. The priorities might be out of order, or try clicking the dropdowns and there might be an empty dropdown option, or open the browser developer tools and notice the option values in the select are missing value=3. 4. Apply patch and restart memcached 5. Check out an item to the 2nd priority borrower 6. Check the existing holds table for the biblio. Confirm the priorities have been fixed and are now consecutive with no gaps. Sponsored-by: Chartered Accountants Australia and New Zealand Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24688 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.05 |20.05.00, 19.11.05, released in| |19.05.10 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.10 -- You are receiving this mail because: You are watching all bug changes.