[Bug 23409] New: Show borrowernotes and opacnote's lines feeds (staff and opac)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Bug ID: 23409 Summary: Show borrowernotes and opacnote's lines feeds (staff and opac) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arnaud@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently, lines feeds typed in borrowernotes and opacnote are not visible in the interface. Patch is coming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show borrowernotes and |Show borrowernotes and |opacnote's lines feeds |opacnote's lines feeds |(staff and opac) |(staff) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 91905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91905&action=edit Bug 23409 - show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, I think there is a nicer way to solve this using TT filters. I've seen them used in quite a few places already. http://www.template-toolkit.org/docs/manual/Filters.html#section_html_line_b... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91905|0 |1 is obsolete| | --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 91906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91906&action=edit Bug 23409 - show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Instead of: + [% FILTER html_line_break %] + [% patron.opacnote | html %] + [% END %] You can just do: [% patron.opacnote | html | html_line_break %] (I think we first want to espace, then make br so the br are not esacped) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23194 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
Instead of:
+ [% FILTER html_line_break %] + [% patron.opacnote | html %] + [% END %]
You can just do:
[% patron.opacnote | html | html_line_break %]
(I think we first want to espace, then make br so the br are not esacped)
Indeed, its much better ;) See existing : [% subscription.notes | html | html_line_break %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- patron.opacnote exists in other places : koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc borrowernotes exists in a lot of other places. BTW html filter should always be used, not $raw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alex, will you have a chance to submit an updated patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91906|0 |1 is obsolete| | --- Comment #8 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 92172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92172&action=edit Bug 23409 - show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92172|0 |1 is obsolete| | --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 92173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92173&action=edit Bug 23409: show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22702 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92173|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92246&action=edit Bug 23409: show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92247&action=edit Bug 23409: (follow-up) Allow HTML in circulation note and add line breaks in OPAC user account This patch makes 2 changes: - bug 22702 allowed adding HTML to the circulation note, so this patch restores that ability. - display OPAC note and messages as multi-line in OPAC To test: - Add a circulation and an OPAC note with line breaks and HTML tags to the patron account - Add a message with line breaks to the patron account - Check line breaks don't show on - OPAC > patron account > my summary page - Staff > patron account > details - Apply patches - Repeat test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Added a follow-up - can you check Alex? Changes in OPAC are debatable on this bug report, but I think we really need to put back the $raw because of bug 22702. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show borrowernotes and |Show circulation note and |opacnote's lines feeds |OPAC note with line feeds |(staff) | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92246|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99712&action=edit Bug 23409: show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92247|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99713&action=edit Bug 23409: (follow-up) Allow HTML in circulation note and add line breaks in OPAC user account This patch makes 2 changes: - bug 22702 allowed adding HTML to the circulation note, so this patch restores that ability. - display OPAC note and messages as multi-line in OPAC To test: - Add a circulation and an OPAC note with line breaks and HTML tags to the patron account - Add a message with line breaks to the patron account - Check line breaks don't show on - OPAC > patron account > my summary page - Staff > patron account > details - Apply patches - Repeat test Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Notes and messages show line breaks in OPAC, Notes on staff HTML tags are processed in circulation notes No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99712|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101386&action=edit Bug 23409: show borrowernotes and opacnote's lines feeds Test plan: - Fill borrowernotes and opacnote with lines separated by lines endings, - save and check the content is displayed on a single line, - apply this patch, - check lines endings are displayed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99713|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101387&action=edit Bug 23409: (follow-up) Allow HTML in circulation note and add line breaks in OPAC user account This patch makes 2 changes: - bug 22702 allowed adding HTML to the circulation note, so this patch restores that ability. - display OPAC note and messages as multi-line in OPAC To test: - Add a circulation and an OPAC note with line breaks and HTML tags to the patron account - Add a message with line breaks to the patron account - Check line breaks don't show on - OPAC > patron account > my summary page - Staff > patron account > details - Apply patches - Repeat test Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Notes and messages show line breaks in OPAC, Notes on staff HTML tags are processed in circulation notes No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.05 released in| | CC| |joy@bywatersolutions.com --- Comment #18 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23409 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting enchancment to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org