[Bug 42980] New: ILL Batches: Have a 'select for all' option when using AutoILLBackendPriority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 Bug ID: 42980 Summary: ILL Batches: Have a 'select for all' option when using AutoILLBackendPriority Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com Target Milestone: --- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41249 [Bug 41249] ILL batches should be compatible with AutoILLBackendPriority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 --- Comment #1 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 201431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201431&action=edit Bug 42980: Add 'apply to all rows' backend selector to ILL batch modal When AutoILLBackendPriority is enabled, adds a selector bar above the staged requests table allowing a backend to be applied to all rows at once. Rows where the selected backend is disabled are skipped. Extracts isBackendEnabled() to avoid duplicating the enabled/disabled condition. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 --- Comment #2 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 201432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201432&action=edit Bug 42980: Add Cypress tests for the select-all backend selector Tests cover: - Bar appears after staging and shows one option per backend - Select-all applies a backend to all rows where it is enabled - Select-all skips rows where the selected backend is disabled Also fixes the existing ILL Batches tests by isolating AutoILLBackendPriority (saves + clears in beforeEach, restores in afterEach) so tests don't fail if a previous run left the syspref dirty. Test plan: 1. Enable ILLModule 2. Install a backend compatible with ILL batches + AutoILLBackendPriority sys pref: https://github.com/openfifth/koha-ill-backend-plugin/releases/tag/v2.0.8 3. Install a metadata enrichment plugin (required for ILL batches): https://github.com/openfifth/koha-plugin-api-pubmed/releases/tag/1.1.1 4. Enable AutoILLBackendPriority sys pref by checking 'PluginBackend' 5. Visit the ILL module: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 6. Notice the 'New ILL requests batch' button shows. Click it. 7. Enter any name, '42' for cardnumber and any library. Click 'Continue'. 8. On the textarea that shows, enter the following pubmed IDs (one per line): 123 321 456 9. Notice that 'PluginBackend' will sometimes be red, sometimes yellow and sometimes green. This is a test backend and that will happen randomly. Repeat step 8) for more test result samples. 10. Notice that when green, 'PluginBackend' will be pre-selected. When yellow, it'll allow you to select it but not pre-select it. When red it doesn't allow it to be selected at all. 11. Notice an 'Apply to all rows:' bar appears above the table for each backend ('PluginBackend' and 'Standard'). 12. Click 'PluginBackend' on the 'Apply to all rows:' bar. Confirm that all rows where 'PluginBackend' is green or yellow switch to it. Confirm that rows where it is red are skipped and stay on 'Standard'. 13. Click 'Standard' on the 'Apply to all rows:' bar. Confirm all 14. Play around with the per-row and select-all selectors, then click 'Add items to batch' and verify that each request was created with the backend that was selected for that row. 15. On a fresh ktd (not after going through the test plan), run the Cypress tests: yarn cypress run --spec t/cypress/integration/ILL/Batches_spec.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edith.speller@ukhsa.gov.uk, | |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 --- Comment #3 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 203047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203047&action=edit Bug 42980: (follow-up) Disable select-all backend bar until all rows finish checking Rows are checked sequentially with real network calls, so the bar could be clicked while later rows were still pending, silently skipping them. Disable the bar while processIdentifiers() is running, re-enable once every row is done. Test plan: 1. yarn cypress run --spec t/cypress/integration/ILL/Batches_spec.ts 2. Stage 2+ identifiers with AutoILLBackendPriority on, confirm the bar stays disabled until all rows finish checking. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201431|0 |1 is obsolete| | Attachment #201432|0 |1 is obsolete| | Attachment #203047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 --- Comment #4 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 203091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203091&action=edit Bug 42980: Add 'apply to all rows' backend selector to ILL batch modal When AutoILLBackendPriority is enabled, adds a selector bar above the staged requests table allowing a backend to be applied to all rows at once. Rows where the selected backend is disabled are skipped. Extracts isBackendEnabled() to avoid duplicating the enabled/disabled condition. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 --- Comment #5 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 203092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203092&action=edit Bug 42980: Add Cypress tests for the select-all backend selector Tests cover: - Bar appears after staging and shows one option per backend - Select-all applies a backend to all rows where it is enabled - Select-all skips rows where the selected backend is disabled Also fixes the existing ILL Batches tests by isolating AutoILLBackendPriority (saves + clears in beforeEach, restores in afterEach) so tests don't fail if a previous run left the syspref dirty. Test plan: 1. Enable ILLModule 2. Install a backend compatible with ILL batches + AutoILLBackendPriority sys pref: https://github.com/openfifth/koha-ill-backend-plugin/releases/tag/v2.0.8 3. Install a metadata enrichment plugin (required for ILL batches): https://github.com/openfifth/koha-plugin-api-pubmed/releases/tag/1.1.1 4. Enable AutoILLBackendPriority sys pref by checking 'PluginBackend' 5. Visit the ILL module: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 6. Notice the 'New ILL requests batch' button shows. Click it. 7. Enter any name, '42' for cardnumber and any library. Click 'Continue'. 8. On the textarea that shows, enter the following pubmed IDs (one per line): 123 321 456 9. Notice that 'PluginBackend' will sometimes be red, sometimes yellow and sometimes green. This is a test backend and that will happen randomly. Repeat step 8) for more test result samples. 10. Notice that when green, 'PluginBackend' will be pre-selected. When yellow, it'll allow you to select it but not pre-select it. When red it doesn't allow it to be selected at all. 11. Notice an 'Apply to all rows:' bar appears above the table for each backend ('PluginBackend' and 'Standard'). 12. Click 'PluginBackend' on the 'Apply to all rows:' bar. Confirm that all rows where 'PluginBackend' is green or yellow switch to it. Confirm that rows where it is red are skipped and stay on 'Standard'. 13. Click 'Standard' on the 'Apply to all rows:' bar. Confirm all 14. Play around with the per-row and select-all selectors, then click 'Add items to batch' and verify that each request was created with the backend that was selected for that row. 15. On a fresh ktd (not after going through the test plan), run the Cypress tests: yarn cypress run --spec t/cypress/integration/ILL/Batches_spec.ts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42980 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 203093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203093&action=edit Bug 42980: (follow-up) Disable select-all backend bar until all rows finish checking Rows are checked sequentially with real network calls, so the bar could be clicked while later rows were still pending, silently skipping them. Disable the bar while processIdentifiers() is running, re-enable once every row is done. Test plan: 1. yarn cypress run --spec t/cypress/integration/ILL/Batches_spec.ts 2. Stage 2+ identifiers with AutoILLBackendPriority on, confirm the bar stays disabled until all rows finish checking. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org