[Bug 35895] New: Reindent tags review template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Bug ID: 35895 Summary: Reindent tags review template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I would like to update tabs/review.tt so that it has consistent indentation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161339&action=edit Bug 35895: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161339|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161340&action=edit Bug 35895: Reindent tags review template This patch reindents the tags review template so that it has consistent indentation, with tab indentation coverted to space. The patch also adds "FILTER collapse" around the <style> block in the head of the page. To test, apply the patch and go to Tools -> Tags. - The page should look unchanged. - Test that no functionality has been affected: - Tag searches - Tag status changes - Check lists - If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161341&action=edit Bug 35895: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161340|0 |1 is obsolete| | Attachment #161341|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161845&action=edit Bug 35895: Reindent tags review template This patch reindents the tags review template so that it has consistent indentation, with tab indentation coverted to space. The patch also adds "FILTER collapse" around the <style> block in the head of the page. To test, apply the patch and go to Tools -> Tags. - The page should look unchanged. - Test that no functionality has been affected: - Tag searches - Tag status changes - Check lists - If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161846&action=edit Bug 35895: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161845|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161916&action=edit Bug 35895: Reindent tags review template This patch reindents the tags review template so that it has consistent indentation, with tab indentation coverted to space. The patch also adds "FILTER collapse" around the <style> block in the head of the page. To test, apply the patch and go to Tools -> Tags. - The page should look unchanged. - Test that no functionality has been affected: - Tag searches - Tag status changes - Check lists - If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161846|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 161917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161917&action=edit Bug 35895: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. PA ammended: IF message_loo -> IF message_loop Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161916|0 |1 is obsolete| | Attachment #161917|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163454&action=edit Bug 35895: Reindent tags review template This patch reindents the tags review template so that it has consistent indentation, with tab indentation coverted to space. The patch also adds "FILTER collapse" around the <style> block in the head of the page. To test, apply the patch and go to Tools -> Tags. - The page should look unchanged. - Test that no functionality has been affected: - Tag searches - Tag status changes - Check lists - If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 163455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163455&action=edit Bug 35895: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163454|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 163666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163666&action=edit Bug 35895: Reindent tags review template This patch reindents the tags review template so that it has consistent indentation, with tab indentation coverted to space. The patch also adds "FILTER collapse" around the <style> block in the head of the page. To test, apply the patch and go to Tools -> Tags. - The page should look unchanged. - Test that no functionality has been affected: - Tag searches - Tag status changes - Check lists - If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163455|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 163667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163667&action=edit Bug 35895: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163666|0 |1 is obsolete| | Attachment #163667|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166144&action=edit Bug 35895: Reindent tags review template This patch reindents the tags review template so that it has consistent indentation, with tab indentation coverted to space. The patch also adds "FILTER collapse" around the <style> block in the head of the page. To test, apply the patch and go to Tools -> Tags. - The page should look unchanged. - Test that no functionality has been affected: - Tag searches - Tag status changes - Check lists - If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166145&action=edit Bug 35895: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35895 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #16 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Code structure change, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org