[Bug 36671] New: Reindent item transfer template (branchtransfers.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Bug ID: 36671 Summary: Reindent item transfer template (branchtransfers.tt) Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 31671 I would like to update circ/branchtransfers.tt so that it has consistent indentation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671 [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 165329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165329&action=edit Bug 36671: Reindent item transfer template (branchtransfers.tt) This patch reindents the item transfer template so that it has consistent indentation, with tab indentation converted to space. To test, apply the patch and go to Circulation -> Transfer. Test some transfers, including transfers which trigger a hold notification. Everything should work correctly. If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 165330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165330&action=edit Bug 36671: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165340&action=edit Bug 36671: Reindent item transfer template (branchtransfers.tt) This patch reindents the item transfer template so that it has consistent indentation, with tab indentation coverted to space. To test, apply the patch and go to Circulation -> Transfer. Test some transfers, including transfers which trigger a hold notification. Everything should work correctly. If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165330|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165341&action=edit Bug 36671: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165342&action=edit Bug 36671: (follow-up) remove stray anchor tag Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Attachment #165329|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165340|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165366&action=edit Bug 36671: Reindent item transfer template (branchtransfers.tt) This patch reindents the item transfer template so that it has consistent indentation, with tab indentation coverted to space. To test, apply the patch and go to Circulation -> Transfer. Test some transfers, including transfers which trigger a hold notification. Everything should work correctly. If you view the diff while ignoring whitespace the only changes should be places where line breaks were introduced. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165341|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165367&action=edit Bug 36671: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165342|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165368&action=edit Bug 36671: (follow-up) remove stray anchor tag Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice bit of cleanup, great work. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Code formatting change, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org