[Bug 15090] New: Fix date filter for Suggestions management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Bug ID: 15090 Summary: Fix date filter for Suggestions management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Bug 13813 introduced an error with datefilters in Home > Acquisitions > Suggestions management See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 Before 1383 the "from" date was 0000-00-00 if not filled, now it's today. This patch re-introduces 0000-00-00. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |veron@veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13813 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Marc Véron <veron@veron.ch> --- Ccing Jonathan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 44201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44201&action=edit Bug 15090: Fix date filter for Suggestions management Home > Acquisitions > Suggestions management: Before 13813 the "from" date in filters was 0000-00-00 if not filled, afer 13813 it's today. This patch re-introduces 0000-00-00. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 To test: - Go to Home > Acquisitions > Suggestions management - Verify that date filters work as expected - Verify that start dates in sql query are 0000-00-00 if no start dates are given - Note: Line 185 outputs the start dates as warn if $debug is set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Priority|P5 - low |P1 - high Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44201|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44258&action=edit Bug 15090: Fix date filter for Suggestions management Home > Acquisitions > Suggestions management: Before 13813 the "from" date in filters was 0000-00-00 if not filled, afer 13813 it's today. This patch re-introduces 0000-00-00. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 To test: - Go to Home > Acquisitions > Suggestions management - Verify that date filters work as expected - Verify that start dates in sql query are 0000-00-00 if no start dates are given - Note: Line 185 outputs the start dates as warn if $debug is set. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44258|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44279&action=edit [PASSED QA] Bug 15090: Fix date filter for Suggestions management Home > Acquisitions > Suggestions management: Before 13813 the "from" date in filters was 0000-00-00 if not filled, afer 13813 it's today. This patch re-introduces 0000-00-00. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 To test: - Go to Home > Acquisitions > Suggestions management - Verify that date filters work as expected - Verify that start dates in sql query are 0000-00-00 if no start dates are given - Note: Line 185 outputs the start dates as warn if $debug is set. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Architecture, internals, |Acquisitions |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org