[Bug 15053] New: sample_creator_data.sql now fails during a fresh install
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Bug ID: 15053 Summary: sample_creator_data.sql now fails during a fresh install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle.m.hall@gmail.com QA Contact: testopia@bugs.koha-community.org ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43854&action=edit Bug 15053 - sample_creator_data.sql now fails during a fresh install ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 Test Plan: 1) Start fresh install 2) Install all test data 3) Note the SQL error 4) Apply this patch 5) Repeat steps 1 and 2 6) Note no error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 15064 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43854|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44006&action=edit [SIGNED-OFF] Bug 15053 - sample_creator_data.sql now fails during a fresh install ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 Test Plan: 1) Start fresh install 2) Install all test data 3) Note the SQL error 4) Apply this patch 5) Repeat steps 1 and 2 6) Note no error Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All fixed files loads without problem. No errors found -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44007&action=edit Bug 15053: Followup for french file Fixes french sample creators data To test: 1 ) Apply the patch 2) Remove sample creator date delete from creator_layouts; delete from creator_templates; delete from printers_profile 3) Load fr-FR/2-Optionel/sample_labels.sql Without the patch french file can't be loaded -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- $ git grep -l labels_t I think Russian and Ukrainian are broken as well. Please submit follow ups for those, so I can just sign off everyone accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44007|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44125&action=edit Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data Fixes other sample creators data To test: 1 ) Apply the patch 2) Remove sample creator date delete from creator_layouts; delete from creator_templates; delete from printers_profile 3) Load fr-FR/2-Optionel/sample_labels.sql or ru-RU/optional/print_labels.sql or uk-UA/optional/print_labels.sql Without the patch this files can't be loaded Test all of them In case of ru and uk I removed a patron card layout -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to M. Tompsett from comment #5)
$ git grep -l labels_t I think Russian and Ukrainian are broken as well. Please submit follow ups for those, so I can just sign off everyone accordingly.
Uploaded some kind of fix for ru and uk -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 44125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44125 Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data Review of attachment 44125: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15053&attachment=44125) ----------------------------------------------------------------- Same for both RU and UK files. ::: installer/data/mysql/ru-RU/optional/print_labels.sql @@ -17,5 @@
-LOCK TABLES `labels_conf` WRITE; -/*!40000 ALTER TABLE `labels_conf` DISABLE KEYS */; -INSERT INTO `labels_conf` -(id,barcodetype,title,subtitle,itemtype,barcode,dewey,classification,subclass,itemcallnumber,author,issn,isbn,startlabel, -printingtype,formatstring,layoutname,guidebox,active,fonttype,ccode,callnum_split)
Why remove the fields list completely? It would have been good to keep updated. @@ -21,5 @@
-printingtype,formatstring,layoutname,guidebox,active,fonttype,ccode,callnum_split) -VALUES -(5,'CODE39',2,0,3,0,0,0,0,4,1,0,0,1,'BIBBAR','библио-запись и штрих-код',1,1,NULL,NULL,NULL,NULL), -(6,'CODE39',2,0,0,0,0,3,4,0,1,0,3,1,'BAR','переменный',1,1,NULL,NULL,NULL,NULL), -(7,'CODE39',1,NULL,NULL,NULL,NULL,NULL,NULL,NULL,2,NULL,NULL,1,'PATCRD','Карточки идентификации посетителей',1,NULL,NULL,NULL,NULL,NULL);
This last one looks strange, but why not keep the strange data? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> ---
Why remove the fields list completely? It would have been good to keep updated.
Table names have changed. Column names have changed. There is a different number of columns now. This is really old data
This last one looks strange, but why not keep the strange data?
Because that data need to be fixed to be loaded. I'm in other things right now, that's the reason I don't fix them in the first place, only french data in which I simply added a couple of columns. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> ---
-(5,'CODE39',2,0,3,0,0,0,0,4,1,0,0,1,'BIBBAR','библио-запись и штрих-код',1,1,NULL,NULL,NULL,NULL), -(6,'CODE39',2,0,0,0,0,3,4,0,1,0,3,1,'BAR','переменный',1,1,NULL,NULL,NULL,NULL), -(7,'CODE39',1,NULL,NULL,NULL,NULL,NULL,NULL,NULL,2,NULL,NULL,1,'PATCRD','Карточки идентификации посетителей',1,NULL,NULL,NULL,NULL,NULL);
From this I only removed the last one, patron card data, 1 & 2 in my patch are equivalent to 5 & 6
(1,'CODE39',1,'BIBBAR','библио-запись и штрих-код',0,1,'TR',7,'POINT',0,'L','title, author, itemcallnumber', '<opt></opt>', 'Labels'), (2,'CODE39',1,'BAR','переменный',0,1,'TR',3,'POINT',0,'L','','','Labels'); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Wow... That error in comment #1 was hard to notice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Any logic with printers_profile should be placed BEFORE the creators_layout and creators_templates logic in: installer/data/mysql/de-DE/optional/sample_creator_data.sql installer/data/mysql/en/optional/sample_creator_data.sql installer/data/mysql/es-ES/optional/sample_creator_data.sql installer/data/mysql/it-IT/necessari/sample_creator_data.sql installer/data/mysql/nb-NO/2-Valgfritt/sample_creator_data.sql to completely avoid errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44006|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44159&action=edit [SIGNED OFF] Bug 15053: sample_creator_data.sql now fails during a fresh install ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 Test Plan: 1) Start fresh install 2) Install all test data 3) Note the SQL error 4) Apply this patch 5) Repeat steps 1 and 2 6) Note no error Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All fixed files loads without problem. No errors found Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44125|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44160&action=edit [SIGNED OFF] Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data Fixes other sample creators data To test: 1 ) Apply the patch 2) Remove sample creator date delete from creator_layouts; delete from creator_templates; delete from printers_profile 3) Load fr-FR/2-Optionel/sample_labels.sql or ru-RU/optional/print_labels.sql or uk-UA/optional/print_labels.sql Without the patch this files can't be loaded Test all of them In case of ru and uk I removed a patron card layout Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What is this labels_templates table? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #15)
What is this labels_templates table?
Old data for an old table I suppose, forget to change the comment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- Please don't forget about comment #12. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to M. Tompsett from comment #17)
Please don't forget about comment #12. :)
Do this patches introduce the problem you mention? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Tomás Cohen Arazi from comment #18)
(In reply to M. Tompsett from comment #17)
Please don't forget about comment #12. :)
Do this patches introduce the problem you mention?
These patches do correct the error in comment #1. They do not introduce new errors, as far as I can tell. But a: truncate blah 1 truncate blah 2 truncate blah 3 source blah 4 where blah 1..3 = the creator_ tables and printers_profile and where blah 4 is in a nice loop for each of the 8 files. (I ignored pl-PL) -- I believe this does have an error. I'll retest later to be sure. But like comment #12 says, printers_profile stuff before the other stuff dealt with it. I suspect it is because cascading creates a printers_profile entry, but I didn't look closely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to M. Tompsett from comment #19)
(In reply to Tomás Cohen Arazi from comment #18)
(In reply to M. Tompsett from comment #17)
Please don't forget about comment #12. :)
Do this patches introduce the problem you mention?
These patches do correct the error in comment #1. They do not introduce new errors, as far as I can tell. But a: truncate blah 1 truncate blah 2 truncate blah 3 source blah 4 where blah 1..3 = the creator_ tables and printers_profile and where blah 4 is in a nice loop for each of the 8 files. (I ignored pl-PL) -- I believe this does have an error. I'll retest later to be sure. But like comment #12 says, printers_profile stuff before the other stuff dealt with it. I suspect it is because cascading creates a printers_profile entry, but I didn't look closely.
Yes, please. Re-test and fill a bug if your suspicion is correct. 3.22 needs to be rock solid. As all Koha releases ;-) Thanks for taking the time to do this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #21 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Tomás Cohen Arazi from comment #20)
Yes, please. Re-test and fill a bug if your suspicion is correct. 3.22 needs to be rock solid. As all Koha releases ;-) Thanks for taking the time to do this.
No errors thus far in the retest. I'll file a bug to remove all warnings. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15086 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 [Bug 15086] Creators layout and template sql has warnings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Second patch does not work: mysql koha_empty < installer/data/mysql/fr-FR/2-Optionel/sample_labels.sql ERROR 1136 (21S01) at line 15: Column count doesn't match value count at row 1 [koha@koha-qa:~/src (BZ15053) ✭]% mysql koha_empty < installer/data/mysql/ru-RU/optional/print_labels.sql ERROR 1136 (21S01) at line 19: Column count doesn't match value count at row 1 [koha@koha-qa:~/src (BZ15053) ✭]% mysql koha_empty < installer/data/mysql/uk-UA/optional/print_labels.sql ERROR 1136 (21S01) at line 21: Column count doesn't match value count at row 1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #22)
Second patch does not work:
mysql koha_empty < installer/data/mysql/fr-FR/2-Optionel/sample_labels.sql ERROR 1136 (21S01) at line 15: Column count doesn't match value count at row 1
[koha@koha-qa:~/src (BZ15053) ✭]% mysql koha_empty < installer/data/mysql/ru-RU/optional/print_labels.sql ERROR 1136 (21S01) at line 19: Column count doesn't match value count at row 1
[koha@koha-qa:~/src (BZ15053) ✭]% mysql koha_empty < installer/data/mysql/uk-UA/optional/print_labels.sql ERROR 1136 (21S01) at line 21: Column count doesn't match value count at row 1
$ git log --oneline | head -4 81c151f Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data 9dc6b80 Bug 15053: sample_creator_data.sql now fails during a fresh install 05d3770 Bug 11881: QA follow-up - rename class 5adb226 Bug 11881: Small improvements for Items available for reference $ mysql koha_empty < kohastructure.sql $ mysql koha_empty < ru-RU/optional/print_labels.sql $ mysql koha_empty -e "delete from creator_layouts; delete from creator_templates; delete from printers_profile" $ mysql koha_empty < uk-UA/optional/print_labels.sql $ mysql koha_empty -e "delete from creator_layouts; delete from creator_templates; delete from printers_profile" $ mysql koha_empty < fr-FR/2-Optionel/sample_labels.sql Works for me -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44159|0 |1 is obsolete| | Attachment #44160|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44195&action=edit Bug 15053: sample_creator_data.sql now fails during a fresh install ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 Test Plan: 1) Start fresh install 2) Install all test data 3) Note the SQL error 4) Apply this patch 5) Repeat steps 1 and 2 6) Note no error Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All fixed files loads without problem. No errors found Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44196&action=edit Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data Fixes other sample creators data To test: 1 ) Apply the patch 2) Remove sample creator date delete from creator_layouts; delete from creator_templates; delete from printers_profile 3) Load fr-FR/2-Optionel/sample_labels.sql or ru-RU/optional/print_labels.sql or uk-UA/optional/print_labels.sql Without the patch this files can't be loaded Test all of them In case of ru and uk I removed a patron card layout Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #23)
Works for me
OOpps! Sorry about that Bernardo, indeed it works well. My koha_empty DB was not updated :-/ So again, my apologies. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #27 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #26)
So again, my apologies.
No problem :) Thank you for your work!! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle and Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com, | |katrin.fischer@bsz-bw.de Component|Architecture, internals, |Installation and upgrade |and plumbing |(web-based installer) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org