[Bug 42795] New: Bug 40658 breaks CLI for 25.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Bug ID: 42795 Summary: Bug 40658 breaks CLI for 25.11 Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com This happened when trying to upgrade one of our Koha instances from Koha 25.11.04 to 25.11.05: Setting up koha-common (25.11.05-1) ... Upgrading database schema for INSTANCENAME Use of uninitialized value $reason in concatenation (.) or string at /usr/share/koha/lib/Koha/SearchEngine/Elasticsearch/Indexer.pm line 276. Upgrade to 25.11.04.011 [09:10:41]: Bug 40658 - Ensure local-number is sortable ERROR: Exception 'Koha::Exception' thrown 'Unable to update mappings for index "koha_INSTANCENAME_biblios". Reason was: "". Index needs to be recreated and reindexed' They do not have Elasticsearch enabled, their SearchEngine preference is set to Zebra, but the atomic update still wanted to update Elasticsearch mappings. I needed to check the value of SearchEngine and put an if { } around the atomic update in 251104011.pl to get past this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40658 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40658 [Bug 40658] When sorting by local-number we should use the sort field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Sponsorship status|--- |Sponsored Comma delimited| |Catalyst IT list of Sponsors| | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 200114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200114&action=edit Bug 42795: Don't try to update ES mappings if not using ES This patch wraps a condition around an Elasticsearch mappings update so it only runs if the SearchEngine is set to Elasticsearch. To test (assumes you are running KTD): 1. git checkout v25.11.04-1 2. reset_all (so your dev environment is happily running 25.11.04) 3. sudo service memcached restart && sudo service koha-common restart 4. Log into the staff interface. Go to Koha Administration -> System preferences and search for SearchEngine. Change this to Zebra if not already set. 5. git checkout v25.11.05-1 6. sudo koha-upgrade-schema kohadev 7. Confirm all updates apply as expected To be thorough, run through test plan again, this time changing the SearchEngine setting to Elasticsearch. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate, | |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I think we need a patch for main also? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I didn't realise it had also affected main - do all versions 25.11 and above need a patch? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200114|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 200169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200169&action=edit Bug 42795: [25.11] Don't try to update ES mappings if not using ES This patch wraps a condition around an Elasticsearch mappings update so it only runs if the SearchEngine is set to Elasticsearch. To test (assumes you are running KTD): 1. git checkout v25.11.04-1 2. reset_all (so your dev environment is happily running 25.11.04) 3. sudo service memcached restart && sudo service koha-common restart 4. Log into the staff interface. Go to Koha Administration -> System preferences and search for SearchEngine. Change this to Zebra if not already set. 5. git checkout v25.11.05-1 6. sudo koha-upgrade-schema kohadev 7. Confirm all updates apply as expected To be thorough, run through test plan again, this time changing the SearchEngine setting to Elasticsearch. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200170&action=edit Bug 42795: Do not try to update ES mappings if not using ES patch for main Patch from commit 4efa8ef -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200169|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 200171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200171&action=edit Bug 42795: [25.11] Don't try to update ES mappings if not using ES This patch wraps a condition around an Elasticsearch mappings update so it only runs if the SearchEngine is set to Elasticsearch. To test (assumes you are running KTD): 1. git checkout v25.11.04-1 2. reset_all (so your dev environment is happily running 25.11.04) 3. sudo service memcached restart && sudo service koha-common restart 4. Log into the staff interface. Go to Koha Administration -> System preferences and search for SearchEngine. Change this to Zebra if not already set. 5. git checkout v25.11.05-1 6. sudo koha-upgrade-schema kohadev 7. Confirm all updates apply as expected To be thorough, run through test plan again, this time changing the SearchEngine setting to Elasticsearch. Sponsored-by: Catalyst IT Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|25.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k --- Comment #7 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi Lucas and Aleisha, just to double-check: So we don't need a 26.06 rev here? Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Pedro Amorim (ammopt) from comment #7)
Hi Lucas and Aleisha, just to double-check: So we don't need a 26.06 rev here? Thanks.
Hi Pedro, the patch `Bug 42795: Do not try to update ES mappings if not using ES patch for main` will apply for 26.05 and main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark@hofstetter.at --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 42960 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dghdghfghfgh04@gmail.com --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 42994 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42795 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Keywords|rel_26_05_candidate | Version(s)|26.11.00 |26.11.00,26.05.02 released in| | --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 26.05.x for upcoming 26.05.02 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org