[Bug 43033] New: Holds queue allocate with transport cost matrix can choose impossible holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 Bug ID: 43033 Summary: Holds queue allocate with transport cost matrix can choose impossible holds Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com Target Milestone: --- Something about the retries and the way we build the matrices can fail when there are more holds than items. We have seen instances in libraries where items are being selected for the queue that are not allowed to transfer via the branch limits or the cost matrix -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 201738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201738&action=edit Test with a lot of holds Patch from commit c764227 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se Priority|P5 - low |P1 - high Assignee|koha-bugs@lists.koha-commun |andreas.jonsson@kreablo.se |ity.org | Severity|major |critical --- Comment #2 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- I think this is fairly likely to cause problems at libraries which have many holds so I suggest raising the importance level. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201738|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 --- Comment #3 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 201777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201777&action=edit Bug 43033: Test with a lot of holds Patch from commit d3072e3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 --- Comment #4 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 201778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201778&action=edit Bug 43033: retry allocation with valid items * The representation of the value "infinity" must be reset to -1 at the start of each allocation attempt. * Unallocated items must be spliced out from the candidate arrays in reverse index order. Test plan: 1. Run the unit tests in t/db_dependent/HoldsQueue/TransportCostOptimizations.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201777|0 |1 is obsolete| | Attachment #201778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 201800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201800&action=edit Bug 43033: Test with a lot of holds Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 201801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201801&action=edit Bug 43033: retry allocation with valid items * The representation of the value "infinity" must be reset to -1 at the start of each allocation attempt. * Unallocated items must be spliced out from the candidate arrays in reverse index order. Test plan: 1. Run the unit tests in t/db_dependent/HoldsQueue/TransportCostOptimizations.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201800|0 |1 is obsolete| | Attachment #201801|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43033 --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org