https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39962 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED Circulation| |Recalls function| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39962 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39962 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39962 --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 182808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182808&action=edit Bug 39962: Allocate checkout item to current recalls 1. Set up a recall before applying both of these patches 2. Apply the first patch and notice that the recall still doesn't show, because it was created before the patch was applied 3. Apply this patch, install database updates and restart services 4. Notice your old recall now shows as requested and was allocated the relevant checkout item Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182807|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 182866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182866&action=edit Bug 39962: Allocate item to bib-level recall when checkout chosen When a biblio-level recall is requested, the checkout with the oldest due date is chosen to have its due date adjusted and sent a return notice. However the chosen checkout item isn't assigned to the recall. This makes it hard for Koha to know which item to show as 'recalled' on the biblio detail page. This patch allocates the checked out item that gets chosen for the recall by oldest due date, to the recall in the database. This patch then checks if the item has an attached recall to display recall information on the biblio detail page, rather than checking for if the UseRecalls system preference is enabled. To test: 1) Enable the UseRecalls system preference and set recalls-related circulation rules. 2) Find a record with at least one item 3) Check out an item in this record to Patron B 4) Log into the OPAC as Patron A and place a biblio-level recall on the record 5) View the record on the staff interface and look at the holdings table 6) The checked out item should now also show a message that it is recalled. 7) Cancel the recall 8) Go back to the OPAC as Patron A and this time place an item-level recall on the checked out item 9) View the record on the staff interface and confirm the recall message shows as expected 10) Confirm all tests pass t/db_dependent/Koha/Item.t , t/db_dependent/Koha/Recalls.t , t/db_dependent/Koha/Plugins/Recall_hooks.t Sponsored-by: Auckland University of Technology Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the holdings release notes| |table for a record with | |recalls in the staff | |interface - it now | |correctly shows that a | |recall was placed for | |record-level and item-level | |recalls. | | | |Before this | |change: | |- For record-level | |recalls, the recall status | |was not shown. | |- For | |item-level recalls, the | |recall status was shown | |twice. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39962 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #6)

I have Two questions. [1] The title of this report suggests a display problem. But there is an atomic update. Could you explain further? Also we should not use Koha::Objects in those sql scripts, but pure SQL statements. Cant find that coding guideline right now ;) But just git grep on "Koha::" in db_revs. Just finding a few offenders..

https://wiki.koha-community.org/wiki/Database_updates#DBIx::Class -- You are receiving this mail because: You are watching all bug changes.