https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39962 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Aleisha, I have Two questions. [1] The title of this report suggests a display problem. But there is an atomic update. Could you explain further? Also we should not use Koha::Objects in those sql scripts, but pure SQL statements. Cant find that coding guideline right now ;) But just git grep on "Koha::" in db_revs. Just finding a few offenders.. [2] You make various small changes in modules but we have no tests.. Could you add them or explain why it is too hard to do so in this case ? Thanks -- You are receiving this mail because: You are watching all bug changes.