[Bug 39696] New: Low contrast for claim return date in circulation overdue report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Bug ID: 39696 Summary: Low contrast for claim return date in circulation overdue report Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Steps to Reproduce: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows and has poor contrast on grey rows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 181261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181261&action=edit Bug 39696: Enhanced text contrast by changing it to black Steps to test: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows and has poor contrast on grey rows. 6. Apply the patch 7. Yarn build 8. Clear cache in browser and observe the display: the claim return date text is now #000 (black). 9. Sign off and have an amazing day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181261|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 181569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181569&action=edit Bug 39696: Enhanced text contrast by changing it to black Steps to test: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows and has poor contrast on grey rows. 6. Apply the patch 7. Yarn build 8. Clear cache in browser and observe the display: the claim return date text is now #000 (black). 9. Sign off and have an amazing day! :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the color of the release notes| |date in the return claims | |column on the overdues page | |(Circulation > Overdues > | |Overdues) - the date is now | |shown in black, instead of | |white. | | | |Previously, the | |date shown after a claim | |returned action is | |completed was white. The | |date not visible in rows | |with a white background, | |and was almost invisible in | |rows with a grey | |background. CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Step 3: Circulation > Overdues > Overdues. 2. Step 5: Even though the table cell under the "Return claims" column looks empty, use your mouse to select the text in the cell (for mouse users). I will now have an amazing day! 8-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I'm not so sure about this change, it affects ALL badges and could well be making other badges of different colors worse to make this one better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182085&action=edit Bug 39696: (Alternative) Set text-bg-info on badge With bootstrap 5, a 'badge' class should always be accompanied by a text-bg-# class. This second class sets the badge color and an appropriate forground text color to ensure appropriate contrast. Steps to test: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows andi has poor contrast on grey rows. 6. Apply the patch 7. Clear cache in browser and observe the display: the claim return date badge is now blue with black text. 8. Sign off and have an amazing day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182086&action=edit Bug 39696: (Alternative follow-up) Set text-bg-info on badge We also use a badge without a text-bg-# class on the modal claims include.. this patch adds the same text-bg-info to that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate, | |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Martin Renvoize (ashimema) from comment #4)
I'm not so sure about this change, it affects ALL badges and could well be making other badges of different colors worse to make this one better.
Added Owen to get his input on the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181569|0 |1 is obsolete| | Attachment #182085|0 |1 is obsolete| | Attachment #182086|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182163&action=edit Bug 39696: (Alternative) Set text-bg-info on badge With bootstrap 5, a 'badge' class should always be accompanied by a text-bg-# class. This second class sets the badge color and an appropriate forground text color to ensure appropriate contrast. Steps to test: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows and has poor contrast on grey rows. 6. Apply the patch 7. Clear cache in browser and observe the display: the claim return date badge is now blue with black text. 8. Sign off and have an amazing day! :D Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182164&action=edit Bug 39696: (Alternative follow-up) Set text-bg-info on badge We also use a badge without a text-bg-# class on the modal claims include.. this patch adds the same text-bg-info to that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- I've added some info to the wiki on Bootstrap color classes: https://wiki.koha-community.org/wiki/Bootstrap#Colors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182178&action=edit Bug 39696: Set text-bg-info on badge With bootstrap 5, a 'badge' class should always be accompanied by a text-bg-# class. This second class sets the badge color and an appropriate forground text color to ensure appropriate contrast. Steps to test: 1. Enable the ability to mark items as "Claimed Returned" by setting the ClaimReturnedLostValue system preference. 2. Check out an item to a patron, and backdate the due date so that it becomes overdue. 3. Navigate to: /cgi-bin/koha/circ/overdue.pl to view the overdue item. 4. Mark the item as "Claims Returned". 5. Observe the display: the claim return date text uses #fff (white), which is not visible on white table rows and has poor contrast on grey rows. 6. Apply the patch 7. Clear cache in browser and observe the display: the claim return date badge is now blue with black text. 8. Sign off and have an amazing day! :D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182179&action=edit Bug 39696: (follow-up) Set text-bg-info on badge We also use a badge without a text-bg-# class on the modal claims include.. this patch adds the same text-bg-info to that. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182163|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182164|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39696 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org