[Bug 11699] New: notes entered when receiving are not saved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Bug ID: 11699 Summary: notes entered when receiving are not saved Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 25075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25075&action=edit adding note When in acquisitions you can enter notes on the receive page. Those notes go no where though - they don't show on the invoice as you'd expect or even on the order under 'already received' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 25076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25076&action=edit no note -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25835&action=edit Bug 11699: Notes entered when receiving are not saved Test plan: 1/ Create an order with 2 items 2/ Receive 1 item and enter a note for the order 3/ Verify the note is correctly saved 4/ Receive the second item and enter a note for the order 5/ Verify the note is correctly saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25836&action=edit Bug 11699: ModReceiveOrder should take a hashref in parameter Test plan: prove t/db_dependent/Acquisition.t prove t/db_dependent/Acquisition/Invoices.t prove t/db_dependent/Acquisition/OrderFromSubscription.t all should return green. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Version|3.12 |master Severity|critical |major --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Not sure this is critical. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- I tried to apply it but got: mtompset@ubuntu:~/kohaclone$ git bz apply 11699 Bug 11699 - notes entered when receiving are not saved 25835 - Bug 11699: Notes entered when receiving are not saved 25836 - Bug 11699: ModReceiveOrder should take a hashref in parameter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11699: Notes entered when receiving are not saved fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11699: Notes entered when receiving are not saved When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11699-Notes-entered-when-receiving-are-not-sav-IBUgWg.patch Please rebase. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25835|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25895&action=edit Bug 11699: Notes entered when receiving are not saved Test plan: 1/ Create an order with 2 items 2/ Receive 1 item and enter a note for the order 3/ Verify the note is correctly saved 4/ Receive the second item and enter a note for the order 5/ Verify the note is correctly saved -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25836|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25896&action=edit Bug 11699: ModReceiveOrder should take a hashref in parameter Test plan: prove t/db_dependent/Acquisition.t prove t/db_dependent/Acquisition/Invoices.t prove t/db_dependent/Acquisition/OrderFromSubscription.t all should return green. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25895|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25900&action=edit [SIGNED OFF] Bug 11699: Notes entered when receiving are not saved Revised test plan: 1/ Create an order with 2 items 2/ Receive 1 item and enter a note for the order 3/ Verify the note is not saved The note should be visible on the Mod Order Details screen, but it isn't there. 4/ Apply patch 5/ Receive the second item and enter a note for the order 6/ Verify the note is correctly saved The note is visible on the Mod Order Details screen. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25896|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25901&action=edit [SIGNED OFF] Bug 11699: ModReceiveOrder should take a hashref in parameter Test plan: prove t/db_dependent/Acquisition.t prove t/db_dependent/Acquisition/Invoices.t prove t/db_dependent/Acquisition/OrderFromSubscription.t all should return green. NOTE: Any error messages are the same between master and this patch, and are unrelated to the added/revised tests. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> --- What did I do wrong? nengard@kohavm:~/kohaclone$ git bz apply 11699 Bug 11699 - notes entered when receiving are not saved 25900 - [SIGNED OFF] Bug 11699: Notes entered when receiving are not saved 25901 - [SIGNED OFF] Bug 11699: ModReceiveOrder should take a hashref in parameter Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11699: Notes entered when receiving are not saved Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Acquisition.pm Auto-merging t/db_dependent/Acquisition.t CONFLICT (content): Merge conflict in t/db_dependent/Acquisition.t Failed to merge in the changes. Patch failed at 0001 Bug 11699: Notes entered when receiving are not saved When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/SIGNED-OFF-Bug-11699-Notes-entered-when-receiving--I7IJ4M.patch nengard@kohavm:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- I blame bug 11224. Though, I haven't honestly confirmed that to be the problem point, but it looks like it without checking. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #12 from mathieu saby <mathsabypro@gmail.com> --- See also bug 9416 Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #13 from mathieu saby <mathsabypro@gmail.com> --- And see also bug 10928 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #14 from mathieu saby <mathsabypro@gmail.com> --- the last one is probably a duplicate. I thought the issue was fixed, but it is probably not the case Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jonathan, could you please rebase? I am a bit confused by the merge conflict in Acquisition.t. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #15)
Jonathan, could you please rebase? I am a bit confused by the merge conflict in Acquisition.t.
me too... :-/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #17 from mathieu saby <mathsabypro@gmail.com> --- My bug 11224 altered the UT for Acquisition.t. I cannot make tests (new laptop, no vm on it...) but if you need some information about it, just ask. I will answer you after my work hours. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25900|0 |1 is obsolete| | Attachment #25901|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26273&action=edit Bug 11699: Notes entered when receiving are not saved Revised test plan: 1/ Create an order with 2 items 2/ Receive 1 item and enter a note for the order 3/ Verify the note is not saved The note should be visible on the Mod Order Details screen, but it isn't there. 4/ Apply patch 5/ Receive the second item and enter a note for the order 6/ Verify the note is correctly saved The note is visible on the Mod Order Details screen. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26274&action=edit Bug 11699: ModReceiveOrder should take a hashref in parameter Test plan: prove t/db_dependent/Acquisition.t prove t/db_dependent/Acquisition/Invoices.t prove t/db_dependent/Acquisition/OrderFromSubscription.t all should return green. NOTE: Any error messages are the same between master and this patch, and are unrelated to the added/revised tests. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26273|0 |1 is obsolete| | Attachment #26274|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26289&action=edit [PASSED QA] Bug 11699: Notes entered when receiving are not saved Revised test plan: 1/ Create an order with 2 items 2/ Receive 1 item and enter a note for the order 3/ Verify the note is not saved The note should be visible on the Mod Order Details screen, but it isn't there. 4/ Apply patch 5/ Receive the second item and enter a note for the order 6/ Verify the note is correctly saved The note is visible on the Mod Order Details screen. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Works as described. The note now saves correctly and also remains when you undo a receipt. Note: it would be nice to show the note on the receive page as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26290&action=edit [PASSED QA] Bug 11699: ModReceiveOrder should take a hashref in parameter Test plan: prove t/db_dependent/Acquisition.t prove t/db_dependent/Acquisition/Invoices.t prove t/db_dependent/Acquisition/OrderFromSubscription.t all should return green. NOTE: Any error messages are the same between master and this patch, and are unrelated to the added/revised tests. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #22 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9416 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11699 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #23 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 I've manually corrected conflicts in Acquisition.t -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org