[Bug 9416] New: We should have 2 kinds of notes for each order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Bug ID: 9416 Summary: We should have 2 kinds of notes for each order line Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.saby@univ-rennes2.fr In aqorders table, we just have a field "notes". In my library we want to store 2 types of comments for each order line : - a note for collegues (visible only for staff) For example : "Ask Head librarian for call number" - a note for the bookseller (visible on basketgroup printed pdf) For example : "Very urgent" So, what about creating a new field in acqorders table, called "booksellernotes" ? M. Saby Rennes 2 University -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I am working on that. The new note will be included in pdf templates, so that the vendor could read it. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 21293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21293&action=edit Bug 9416: Add a new note for vendor in each order This patch adds a new note made for vendor in each order. The existing note is renamed "internal note". The behavior of the 2 notes are the same An other patch will display this vendor note in pdf printed basketgroups. To test : Make a complete acquisiton process (creating the order > looking at the basket
looking the order > receiving) and try to use the 2 notes (internal note / vendor note) check the changes made on one page (eg detail of the order) are well saved and visible on an other page (eg receipt page)
Note : display of existing acq note is broken on receipt page. It must be fixed in an other bug -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I opened Bug 10928 for the broken display of existing note Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-24 last check this| | --- Comment #4 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21293|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21964&action=edit Bug 9416: Add a new note for vendor in each order This patch adds a new note made for vendor in each order. The existing note is renamed "internal note". The behavior of the 2 notes are the same An other patch will display this vendor note in pdf printed basketgroups. To test : Make a complete acquisiton process (creating the order > looking at the basket
looking the order > receiving) and try to use the 2 notes (internal note / vendor note) check the changes made on one page (eg detail of the order) are well saved and visible on an other page (eg receipt page)
Note : display of existing acq note is broken on receipt page. It must be fixed in an other bug -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #6 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- New attachment ? A problem with sandbox? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-24 00:00:00 |2013-10-30 last check this| | --- Comment #7 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21964|0 |1 is obsolete| | --- Comment #8 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 23798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23798&action=edit Add a new note for vendor in each order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- This patch adds a new note made for vendor in each order. The existing note is renamed "internal note". The behavior of the 2 notes are the same An other patch will display this vendor note in pdf printed basketgroups. Changes in database structure: - new column aqorders.order_vendornote - column aqorders.notes renamed aqorders.order_internalnote To test : Make a complete acquisiton process (creating the order > looking at the basket
looking the order > receiving) and try to use the 2 notes (internal note / vendor note) check the changes made on one page (eg detail of the order) are well saved and visible on an other page (eg receipt page)
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #10 from Marc Véron <veron@veron.ch> --- Wanted to test, but Patch does not apply. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Applying: Bug 9416: Add a new note for vendor in each order fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23798|0 |1 is obsolete| | --- Comment #12 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 25329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25329&action=edit Bug 9416: Add a new note for vendor in each order Patch rebased -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 25335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25335&action=edit [SIGNED-OFF] Bug 9416: Add a new note for vendor in each order This patch adds a new note made for vendor in each order. The existing note is renamed "internal note". The behavior of the 2 notes are the same An other patch will display this vendor note in pdf printed basketgroups. Changes in database structure: - new column aqorders.order_vendornote - column aqorders.notes renamed aqorders.order_internalnote To test : Make a complete acquisiton process (creating the order > looking at the basket
looking the order > receiving) and try to use the 2 notes (internal note / vendor note) check the changes made on one page (eg detail of the order) are well saved and visible on an other page (eg receipt page)
I followed the test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25329|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- This patch modifies Koha/Schema/Result/Aqorder.pm. But it should not; the first part of this file is automatically generated. Please correct your patch by removing this edit. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #15 from mathieu saby <mathsabypro@gmail.com> --- I did not know that... You mean the "comment" part (head2 etc) of the file? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mathieu, maybe this is helpful: http://wiki.koha-community.org/wiki/Database_updates -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #17 from mathieu saby <mathsabypro@gmail.com> --- Indeeed! So I understand that my patch should not include any changes to Koha/Schema/Result/Aqorder.pm, and that the RM will run a script to generate the needed changes. I'm going to edit the patch accordingly. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25335|0 |1 is obsolete| | --- Comment #18 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 27231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27231&action=edit [PATCH] Bug 9416: In each order, add a new note made for the vendor I removed the changes made to Koha/Schema/Result/Aqorder.pm, and improved a bit the description of the patch. Mathieu (Patch edited after QA remark: I removed the changes made to Koha/Schema/Result/Aqorder.pm) Currently, there is a single note field in each order. It could be useful to have 2 notes fields: - one for the staff (ex: "catalog this book as soon as possible") - one for the vendor (ex: "urgent", "only the 2d volume"...), which could lated be printed in basketgroup pdf for example This patch adds a new note made for vendor in each order. The existing note is renamed "internal note". The behavior of the 2 notes are the same An other patch will display this vendor note in pdf printed basketgroups. Changes in database structure: - new column aqorders.order_vendornote - column aqorders.notes renamed aqorders.order_internalnote To test : Make a complete acquisiton process (creating the order > looking at the basket
looking the order > receiving) and try to use the 2 notes (internal note / vendor note) check the changes made on one page (eg detail of the order) are well saved and visible on an other page (eg receipt page)
I followed the test plan, patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27231|0 |1 is obsolete| | --- Comment #19 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 27274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27274&action=edit [PATCH] Bug 9416: In each order, add a new note made for the vendor I fix a conflict in updatedatabase -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 27274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27274 [PATCH] Bug 9416: In each order, add a new note made for the vendor Review of attachment 27274: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9416&attachment=27274) ----------------------------------------------------------------- Hi Mathieu, 1) A few small things in the templates could be improved, I noted those below (minor) 2) On editing an order line an existing internal or vendor note doesn't show up in the input fields (major) 3) Just a note: When I looked at the CSV export I realized it does export the internal note, as before. I wonder how the new vendor note will be used, it doesn't show up on the PDFs or in the CSV export. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/modordernotes.tt @@ +1,2 @@
[% INCLUDE 'doc-head-open.inc' %] +<title>Koha › Acquisition › Change order [% IF (type == "vendor") %]vendor[% ELSE %]internal[% END %] note</title>
Constructs like this are hard to translate. For example in German one translation for vendor note would be Lieferantennotiz - so both words together. And I think in some other languages the adjective would go after the subject. @@ +5,5 @@
<body> [% INCLUDE 'header.inc' %]
+<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisition</a> › <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid %]">[% booksellername|html %]</a> › <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno %]">Basket [% basketname|html %] ([% basketno %])</a> › Change order [% IF (type == "vendor") %]vendor[% ELSE %]internal[% END %] note</div>
Same here. Sometimes being more verbose is good. @@ +11,5 @@
<div id="doc" class="yui-t7">
<div id="bd"> <div id="yui-main"> + <h1>Change order [% IF (type == "vendor") %]vendor[% ELSE %]internal[% END %] note (order no. [% ordernumber %])</h1>
And here. @@ +16,3 @@
<form action="/cgi-bin/koha/acqui/modordernotes.pl" method="post"> <fieldset class="brief"> + <label for="ordernotes">Note:</label>
Should this be vendor or internal note? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #21 from mathieu saby <mathsabypro@gmail.com> ---
Constructs like this are hard to translate. For example in German one translation for vendor note would be Lieferantennotiz
Lovely name ;-) I take a look at that Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27274|0 |1 is obsolete| | --- Comment #22 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 27299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27299&action=edit [PATCH] Bug 9416 [SIGNED OFF] In each order, add a new note made for the vendor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #23 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 27300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27300&action=edit [PATCH 2/3] Bug 9416 QA Followup: fix neworderempty and templates -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #24 from mathieu saby <mathsabypro@gmail.com> --- (In reply to mathieu saby from comment #23)
Created attachment 27300 [details] 0 [PATCH 2/3] Bug 9416 QA Followup: fix neworderempty and templates
This followup answer QA remarks : - neworderempty.pl updated so that the 2 new variables are passed to the template - modordernotes.tt fixed to make the translation easier - in CSV headers, to make clear that no change are made for the moment, rename "note" to "vendor note" Additionnaly, "Publisher code" was wrong in the csv headers. I changed it to "Publisher" (the field in database is publishercode, but the content is a real publisher name, not a code) I did not change "Note:" in modordernotes.tt, because it is just under a h1 tag which specifies the type of note the librarian is being editing Test plan : - edit an existing order, and try to change/add/suppress the vendor note, and the internal note. Check the changes are properly saved - export a basket and a basketgroup in CSV. Check the columns headers are "Publisher" and "Vendor note" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #25 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 27301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27301&action=edit [PATCH 3/3] Bug 9416 : Fix Acquisition.t UT This patch fixes UT, to take into account the new fields order_internalnote and order_vendornote Note that "notes" field is still returned as well by some Acquisition subs (those which return all the fields of biblio and biblioitems table) Test plan : run prove t/db_dependant/Acquisition.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #26 from mathieu saby <mathsabypro@gmail.com> --- For your point 3 "3) Just a note: When I looked at the CSV export I realized it does export the internal note, as before. I wonder how the new vendor note will be used, it doesn't show up on the PDFs or in the CSV export." => For the moment, PDFs and CSV behavior are not changed (only the header of CSV, to describe more precisely the kind of note returned) When the patch is pushed, I will provide an other one to add the vendor note in PDF, and maybe change the behavior of the CSV export -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #27 from mathieu saby <mathsabypro@gmail.com> --- Created attachment 27302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27302&action=edit [PATCH 2/3] Bug 9416 QA Followup: fix neworderempty and templates Oooops Sorry, I made a little mistake in the 2d patch : in the headers of the csv, I wrote "vendor note". Of course, it is "internal note". Fixed Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27300|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mathieu, thx for your fast follow ups! I have been thinking about the construct some more and I think it's still assuming grammatical order: - <h1>Change order [% IF (type == "vendor") %]vendor[% ELSE %]internal[% END %] note (order no. [% ordernumber %])</h1> + <h1>Change order [% IF (type == "vendor") %]vendor note[% ELSE %]internal note[% END %] (order no. [% ordernumber %])</h1> Normally I would try to put the verb at the end of the sentence in German and also pull together order vendor note, which could be even one word in German (yes, German is weird :) ) I'd like best: [% IF (type == "vendor") %] <h1>Change order vendor note (order no. [% ordernumber %])</h1> [% ELSE %] <h1>Change order internal note (order no. [% ordernumber %])</h1> [% END %] I will continue testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27299|0 |1 is obsolete| | Attachment #27301|0 |1 is obsolete| | Attachment #27302|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27304&action=edit 0001-PASSED-QA-SIGNED-OFF-Bug-9416-In-each-order-add-a-ne.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27305&action=edit 0002-PASSED-QA-Bug-9416-Fix-Acquisition.t-UT.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27306&action=edit 0003-PASSED-QA-Bug-9416-QA-Followup-fix-neworderempty-and.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #32 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up to reconcile it with bug 11699 and a follow-up to update the order from staged file code. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #33 from mathieu saby <mathsabypro@gmail.com> --- Thank you Galen for the quick pushing. I see I had forgotten to update addorderiso2709.pl :( For your comment about the usefulness of editing "vendor notes" in receipt page, I will take a look, but I think you are right. As Katrin pointed out a line that could be written better for the translation, I will make a small new patch for that. I will also provide a patch for displaying the "vendor note" in the PDFs (the patch is written, I was just waiting for this one to be pushed...). As this patch is pushed, I suppose the cleaner way to do those changes is to make an other bug for them. For the CSV, I don't know which is better. If the CSV file is generated by libraries in order to be sent to the vendor (as we did in my library), It sounds logicial to me to replace the "internal note" with the "vendor note", but I am not sure everyone will agree. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #34 from mathieu saby <mathsabypro@gmail.com> --- See bugs 12110 and bug 12111 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Depends on| |11699 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org