[Bug 20017] New: use Modern::Perl in Tools perl scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Bug ID: 20017 Summary: use Modern::Perl in Tools perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: background-job-progress.pl batchMod.pl copy-holidays.pl exceptionHolidays.pl holidays.pl import_borrowers.pl koha-news.pl letter.pl manage-marc-import.pl newHolidays.pl overduerules.pl quotes-upload.pl quotes.pl quotes/quotes-upload_ajax.pl quotes/quotes_ajax.pl scheduler.pl stage-marc-import.pl upload-cover-image.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 jwayway@hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 --- Comment #1 from jwayway@hotmail.com --- Created attachment 70664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70664&action=edit Bug-29917: use Modern::Perl in Tools perl scripts Test plan: Check that the following files don't contain use strict; use warnings; and have use Modern::Perl instead. background-job-progress.pl batchMod.pl copy-holidays.pl exceptionHolidays.pl holidays.pl import_borrowers.pl koha-news.pl letter.pl manage-marc-import.pl newHolidays.pl overduerules.pl quotes-upload.pl quotes.pl quotes/quotes-upload_ajax.pl quotes/quotes_ajax.pl scheduler.pl stage-marc-import.pl upload-cover-image.pl Also the credits have been added to newHolidays.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70664|0 |1 is obsolete| | --- Comment #2 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 70900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70900&action=edit Bug-29917: use Modern::Perl in Tools perl scripts Test plan: Check that the following files don't contain use strict; use warnings; and have use Modern::Perl instead. background-job-progress.pl batchMod.pl copy-holidays.pl exceptionHolidays.pl holidays.pl import_borrowers.pl koha-news.pl letter.pl manage-marc-import.pl newHolidays.pl overduerules.pl quotes-upload.pl quotes.pl quotes/quotes-upload_ajax.pl quotes/quotes_ajax.pl scheduler.pl stage-marc-import.pl upload-cover-image.pl Also the credits have been added to newHolidays.pl https://bugs.koha-community.org/show_bug.cgi?id=20017 Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |jwayway@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70900|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71182&action=edit Bug 20017: use Modern::Perl in Tools perl scripts Test plan: Check that the following files don't contain use strict; use warnings; and have use Modern::Perl instead. background-job-progress.pl batchMod.pl copy-holidays.pl exceptionHolidays.pl holidays.pl import_borrowers.pl koha-news.pl letter.pl manage-marc-import.pl newHolidays.pl overduerules.pl quotes-upload.pl quotes.pl quotes/quotes-upload_ajax.pl quotes/quotes_ajax.pl scheduler.pl stage-marc-import.pl upload-cover-image.pl Also the credits have been added to newHolidays.pl https://bugs.koha-community.org/show_bug.cgi?id=20017 Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good job! Please always be careful to put the right bug number in the commit message as this will be used to generate the release notes. Fixed it here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #3)
Also the credits have been added to newHolidays.pl
But not the good one. I am going to amend the patch to remove this part. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement not backported to stable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20305 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20305 [Bug 20305] Warnings in tools scripts need to be removed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org