[Bug 19875] New: When & is in the title of a search result, subscribing via rss can be broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Bug ID: 19875 Summary: When & is in the title of a search result, subscribing via rss can be broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: christophe.croullebois@biblibre.com QA Contact: testopia@bugs.koha-community.org This issue is not in all cases (depend on many factors). It is due to the xml syntax where the use of "&" is forbidden and must be "&" Koha do the job in this line : <title>[% SEARCH_RESULT.title |html %]....... With the use of "|html" But not in this line : Place Hold on <i>[% SEARCH_RESULT.title %]</i>...... The patch is very light just adds "|html" in the line above. ################# Test Plan : 1° in opac do a search where you can find "&" in the title 2° in the result page click on the rss button on the right of "Your search returned n results." (Subscribe to this search) 3° if your subscribe is ok you can not perform the test :o( 4° if your subscribe is nok you can apply the patch 5° test the same work flow with the patch the subscribe must be ok. Thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Christophe, do you plan to attach a patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com Assignee|oleonard@myacpl.org |christophe.croullebois@bibl | |ibre.com Status|NEW |Needs Signoff --- Comment #2 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 70155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70155&action=edit patch thx to test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- (In reply to Jonathan Druart from comment #1)
Hi Christophe, do you plan to attach a patch?
Hi Jonathan, done, thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com --- Comment #4 from Roch D'Amour <roch.damour@inlibro.com> --- I applied the patch, searched for results with a "&" in the title, and subscribed to the RSS feed. The feed show up, but I only get entrys up untill the records with the "&" in the title. After this records, nothing else show up. I followed the test plan, and I was wondering what do you meant by "subscribe is ok | nok"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- (In reply to Roch D'Amour from comment #4)
I applied the patch, searched for results with a "&" in the title, and subscribed to the RSS feed. The feed show up, but I only get entrys up untill the records with the "&" in the title. After this records, nothing else show up. I followed the test plan, and I was wondering what do you meant by "subscribe is ok | nok"?
Hello, what you describe is the result without patch =>nok Effectively if you have 10 result in the search and if a title with "&" is in the row 5, you'll see only the 5 firt rows. After applying the patch you'll see the 10 result and your subscribe must be ok (you can see links active in your browser). Hoping be clearer. Thx for your test Regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70155|0 |1 is obsolete| | --- Comment #6 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 70911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70911&action=edit Bug 19875: escape & in rss feed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Christophe, I am not sure why, but your change breaks the rendering of the RSS is in the browser for me. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 --- Comment #8 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- (In reply to Katrin Fischer from comment #7)
Hi Christophe,
I am not sure why, but your change breaks the rendering of the RSS is in the browser for me. :(
Hi Katrin, in fact I had to close this one because now it is obsolete due to 19568 and his correction on 20286. I have seen when reporting 20286 that there is no more issues with the '&'. So I close this one, thx Katrine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org