[Bug 16325] New: Suggestions: Tab "Status unknown" contains all suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Bug ID: 16325 Summary: Suggestions: Tab "Status unknown" contains all suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Created attachment 50562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50562&action=edit Screenshot with tab "Status unknown" displaying all suggestions To reproduce: - Test on Top of Bug 16322 for better visualization - Create some suggestions - Go to Home > Acquisitions > Suggestions management - Edit some suggestions and give them different status, e.g. accepted, rejected, pending. - Verify that they appear in the tabs as appropriate - Edit one suggestion, set "Mark selected as" to --Choose a status-- - Result: New tab "Status unknown" containing all suggestions (expected: tab contains only suggestion with "Unknown status") See screenshot attached. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16322 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 [Bug 16322] Translatability: "Unknown" in suggestion/suggestion.pl not translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51153&action=edit Bug 16325: Add a test for SearchSuggestions when searching for STATUS='' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51154&action=edit Bug 16325: Do not return all suggestions if search for STATUS='' This is a quick and dirty way to fix a bad bug in a messy area. The "unknown status" tab in the suggestions table display all the suggestions. It should only display suggestions with a STATUS='' Test plan: - Create some suggestions - Go to Home > Acquisitions > Suggestions management - Edit some suggestions and give them different status, e.g. accepted, rejected, pending. - Verify that they appear in the tabs as appropriate - Edit one suggestion, set "Mark selected as" to --Choose a status-- => Without this patch: New tab "Status unknown" containing all suggestions => With this patch: tab contains only suggestions with "Unknown status" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on|16322 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16322 [Bug 16322] Translatability: "Unknown" in suggestion/suggestion.pl not translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51153|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 51159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51159&action=edit Bug 16325: Add a test for SearchSuggestions when searching for STATUS='' Test fails as expected without second patch and passes OK with second patch. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51154|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 51160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51160&action=edit Bug 16325: Do not return all suggestions if search for STATUS='' This is a quick and dirty way to fix a bad bug in a messy area. The "unknown status" tab in the suggestions table display all the suggestions. It should only display suggestions with a STATUS='' Test plan: - Create some suggestions - Go to Home > Acquisitions > Suggestions management - Edit some suggestions and give them different status, e.g. accepted, rejected, pending. - Verify that they appear in the tabs as appropriate - Edit one suggestion, set "Mark selected as" to --Choose a status-- => Without this patch: New tab "Status unknown" containing all suggestions => With this patch: tab contains only suggestions with "Unknown status" Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51159|0 |1 is obsolete| | Attachment #51160|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51259&action=edit [PASSED QA] Bug 16325: Add a test for SearchSuggestions when searching for STATUS='' Test fails as expected without second patch and passes OK with second patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51260&action=edit [PASSED QA] Bug 16325: Do not return all suggestions if search for STATUS='' This is a quick and dirty way to fix a bad bug in a messy area. The "unknown status" tab in the suggestions table display all the suggestions. It should only display suggestions with a STATUS='' Test plan: - Create some suggestions - Go to Home > Acquisitions > Suggestions management - Edit some suggestions and give them different status, e.g. accepted, rejected, pending. - Verify that they appear in the tabs as appropriate - Edit one suggestion, set "Mark selected as" to --Choose a status-- => Without this patch: New tab "Status unknown" containing all suggestions => With this patch: tab contains only suggestions with "Unknown status" Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16325 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org