[Bug 33848] New: Enabling Coce in the OPAC breaks cover images on bibliographic detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Bug ID: 33848 Summary: Enabling Coce in the OPAC breaks cover images on bibliographic detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: andrew.auld@ptfs-europe.com, jbalway@gmail.com, jonathan.druart+koha@gmail.com, lucas@bywatersolutions.com, testopia@bugs.koha-community.org Depends on: 32412 If you enable multiple cover image services, including Coce, the bibliographic detail page in the OPAC doesn't display all covers. Viewing a title with Amazon, Google, Coce, and OpenLibrary, only the Amazon and Google images display. In the console is an error message: Uncaught TypeError: parent.find is not a function getURL http://localhost:8080/opac-tmpl/bootstrap/js/coce_22.1200048.js:20 The script stops processing other sources when Coce fails. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am not recreating the problem. Do you recreate in ktd? If so which biblionumber? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I'm able to reproduce this problem *intermittently* using Firefox, the sample data in master, and with these preferences enabled: OPACAmazonCoverImages OpacCoce GoogleJackets OpenLibraryCovers I perform this search: http://127.0.0.1:8080/cgi-bin/koha/opac-search.pl?q=su:%22C%20Computer%20pro... The first result, "The C programming language," shows four covers, one from each of the services listed above. On the detail page for that result, it only shows three covers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151864&action=edit Bug 33848: Don't remove coce container from template It's removed from coce.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think I've tracked it down, but there are several things that go wrong. First I don't get the error reported in comment 0. However I do see images removed, randomly. I can see 2, 3 or 4. This patch fix the Coce problem, but it is still not working for OpenLibrary. And it is not fixed staff side either. Apparently we reach verify_images before the image is loaded the the code around "KOHA.coce.done" (32307, 28179, 28180) was supposed to prevent that... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 34125 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass from comment on Bug 34125 #0)
To recreate:
1. Turn on Coce. 2. Set OPACURLOpenInNewWindow to 'Do'. 3. Go to an OPAC detail page that should return a Coce image. 4. Nothing loads, and if you look at the console you will see the error 'parent.find is not a function' coming from coce.js
I hadn't made a connection to OPACURLOpenInNewWindow, that makes things all the more confusing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152722&action=edit Bug 33848: Enabling Coce in the OPAC breaks cover images on bibliographic detail page Bug 32412 added an additional "context" parameter to KOHA.coce.getURL. The code which pulls a Coce image for the "main" cover image slider needs to include the correct context parameter for the images to load. This patch also makes a minor correction to CSS in order to make the cover image slider "dots" change color to highlight the current slide. To test, apply the patch and rebuild the OPAC CSS. - Enable multiple cover image sources in the OPAC including Coce, e.g. Amazon, Google, OpenLibrary, etc. - Search for a title which will match multiple cover image sources. In the sample data a search for "Perl" will return good results. - Note the number of cover images loading for a title in the search results. - View the detail page for that title. There should be the same number of covers in the cover image slider. - Clicking the slider navigation dots should work to show each image, and the dot should change color to highlight the current image. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I'm not certain this is the correct solution but it seems to work. I don't know what the connection is to OPACURLOpenInNewWindow though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152722|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152747&action=edit Bug 33848: Enabling Coce in the OPAC breaks cover images on bibliographic detail page Bug 32412 added an additional "context" parameter to KOHA.coce.getURL. The code which pulls a Coce image for the "main" cover image slider needs to include the correct context parameter for the images to load. This patch also makes a minor correction to CSS in order to make the cover image slider "dots" change color to highlight the current slide. To test, apply the patch and rebuild the OPAC CSS. - Enable multiple cover image sources in the OPAC including Coce, e.g. Amazon, Google, OpenLibrary, etc. - Search for a title which will match multiple cover image sources. In the sample data a search for "Perl" will return good results. - Note the number of cover images loading for a title in the search results. - View the detail page for that title. There should be the same number of covers in the cover image slider. - Clicking the slider navigation dots should work to show each image, and the dot should change color to highlight the current image. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What about my patch here? Should I obsolete it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Bug 33848 depends on bug 32412, which changed state. Bug 32412 Summary: OPACShelfBrowser controls add extra Coce images to biblio-cover-slider https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151864|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154063&action=edit Bug 33848: Don't remove coce container from template It's removed from coce.js Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152747|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154064&action=edit Bug 33848: Enabling Coce in the OPAC breaks cover images on bibliographic detail page Bug 32412 added an additional "context" parameter to KOHA.coce.getURL. The code which pulls a Coce image for the "main" cover image slider needs to include the correct context parameter for the images to load. This patch also makes a minor correction to CSS in order to make the cover image slider "dots" change color to highlight the current slide. To test, apply the patch and rebuild the OPAC CSS. - Enable multiple cover image sources in the OPAC including Coce, e.g. Amazon, Google, OpenLibrary, etc. - Search for a title which will match multiple cover image sources. In the sample data a search for "Perl" will return good results. - Note the number of cover images loading for a title in the search results. - View the detail page for that title. There should be the same number of covers in the cover image slider. - Clicking the slider navigation dots should work to show each image, and the dot should change color to highlight the current image. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've tested both patches together in Chromium and Firefox in Ubuntu. I had some difficulty reproducing the original bug, but I see improvements with this patch set, like highlighting of the currently visible picture, and no regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.11.00,23.05.03,22.11.09 |23.11.00,23.05.03,22.11.09, released in| |22.05.17 --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.17 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org