[Bug 24609] New: Add routes for getting and setting checkout due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Bug ID: 24609 Summary: Add routes for getting and setting checkout due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com To allow the work in bug 24608 to proceed, we need an API route to allow the setting of a checkout's due date. I will add a GET route also. The proposed endpoints are: Return a checkout's due date: Method: GET URL: /checkouts/{checkout_id}/date_due Set a checkout's due date: Method: POST URL: /checkouts/{checkout_id}/date_due Body: { date_due: '2020-02-07 10:49:08' } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24608 [Bug 24608] Allow modification of checkout due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Change of plan on this one. It's unnecessary to create a new endpoint for this. Following a discussion with Martin, I've realised we can just add a PUT endpoint for the /checkouts/{checkout_id} route, with whole checkout objects passed as the body. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 [Bug 24650] API returned timestamps are incompatible with existing helpers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24650 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24650 [Bug 24650] API returned timestamps are incompatible with existing helpers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 98924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98924&action=edit Bug 24609: Create PUT /checkouts/{checkout_id} This patch creates a PUT /checkouts/{checkout_id} API route enabling checkouts to be updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 98925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98925&action=edit Bug 24609: Add API unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Test plan: - Apply patch - prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98924|0 |1 is obsolete| | --- Comment #5 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 99021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99021&action=edit Bug 24609: Create PUT /checkouts/{checkout_id} This patch creates a PUT /checkouts/{checkout_id} API route enabling checkouts to be updated Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98925|0 |1 is obsolete| | --- Comment #6 from Lisette Scheer <lisetteslatah@gmail.com> --- Created attachment 99022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99022&action=edit Bug 24609: Add API unit tests Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is something that annoy me with adding such routes. We have lot of switches in Koha (syspref, permissions) that are not taken into account with them. Do we really want to allow anybody with circulate_remaining_permissions to modify a checkout, and so bypassing sysprefs and circulation rules? That sounds a bit wrong to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Thanks for this Jonathan. I guess that then raises the question of whether that logic should go in the route controller? Or whether there should be a centralised location (probably the route spec), which would enable the creator to specify all the conditions that must be met before the route can be accessed. I guess extending what x-koha-authorization does. Having it in the controller feels haphazard and prone to omission, having it a required part of the route spec would be better. But how you would go about defining a way for any arbitrary logic to be specified in a json file would need some thought. Anyway, it feels like this is a question that's bigger than just the addition of this route, do you agree? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Isherwood from comment #8)
Anyway, it feels like this is a question that's bigger than just the addition of this route, do you agree?
It's definitely bigger than this route, do we have already such routes that could be problematic? I have asked Tomas to let a comment with his thoughts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi I'm sorry for the delay to comment on this one. As a general comment, our (current) controller/permissions logic doesn't allow to specify complex conditions. We only check for permissions/ownership, before we reach the controller. [1] So the general rule is that any syspref check or combination of permissions+sysprefs (that can be found in many places in our codebase/templates) should be done either in a high level method (ModIssue?) or the controller itself (e.g. that's why we stash the current user, accesible through $c->stash('koha.user') so we can ask further questions about it. Any authentication method stashes the user for that purpose. That said, changing the date due on a checkout might be something worth having a method in Koha::Checkout->update_due_date so any logic is encapsulated there and, more importantly, the method can be used in other places. Speaking of the current endpoint, we've been observant of the current implementations on the UI to catch all the conditions and prevent misuses of endpoints. This doesn't mean there were no mistakes, but speaking for my contributions, I usually look at the .pl, the .tt and try to put all that logic on the enpdoint. [1] And I'm not sure we should add such a thing to our project as the API hasn't been a target for the refactorings specifically, and so moving existing logic into a (cool) new high level config layer on the spec would mean maintaining two codebases right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The code for update() is missing a ->discard_changes() call before returning $checkout->to_api, so the timestamp does not look updated on the response, Regarding the logic in it, I'm worried about the simplicity and how this might need some round actions to trigger things like account fixes, etc.I'm not saying it is wrong, but it looks suspiciously simple without having dug too much into the area recently (i.e. I would accept an 'is safe' from you, if you say so). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi from comment #11)
The code for update() is missing a ->discard_changes() call before returning $checkout->to_api, so the timestamp does not look updated on the response,
Regarding the logic in it, I'm worried about the simplicity and how this might need some round actions to trigger things like account fixes, etc.I'm not saying it is wrong, but it looks suspiciously simple without having dug too much into the area recently (i.e. I would accept an 'is safe' from you, if you say so).
By 'round' actions, do you mean things like triggering an updateFines call ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I now see what you mean a bit more.. we don't, for example, handle updating the 'items.onloan' field to match the new due date either. I think some of the logic for these 'side effects' ought to be moved into Koha::Checkout::store.. but it'll need a little digging. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 [Bug 24850] Koha::DateUtils ignores offsets in RFC3339 datetimes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99021|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115879&action=edit Bug 24609: Create PUT /checkouts/{checkout_id} This patch creates a PUT /checkouts/{checkout_id} API route enabling checkouts to be updated Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99022|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115880&action=edit Bug 24609: Add API unit tests Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115881&action=edit Bug 24609: Add test for timezone handling This patch adds an additional set of tests for test for how timezones are handled if we are passed an rfc3339 string with a timezone offset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've added a test to highlight the issues faced downstream in bug 24608. We must be able to handle RFC3339 input dates that include a timezone offset... the test will fail prior to applying bug 24850 so I've made it a dependancy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115879|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126191&action=edit Bug 24609: Create PUT /checkouts/{checkout_id} This patch creates a PUT /checkouts/{checkout_id} API route enabling checkouts to be updated Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115880|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126192&action=edit Bug 24609: Add API unit tests Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115881|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126193&action=edit Bug 24609: Add test for timezone handling This patch adds an additional set of tests for test for how timezones are handled if we are passed an rfc3339 string with a timezone offset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126194&action=edit Bug 24609: Add trigger to set items.onloan on due_date update This patch adds an overridden store method to Koha::Checkout to catch due_date changes and trigger an update of the items.onloan field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add routes for getting and |Add routes for updating |setting checkout due date |checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126191|0 |1 is obsolete| | Attachment #126192|0 |1 is obsolete| | Attachment #126193|0 |1 is obsolete| | Attachment #126194|0 |1 is obsolete| | --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 126316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126316&action=edit Bug 24609: Create PUT /checkouts/{checkout_id} This patch creates a PUT /checkouts/{checkout_id} API route enabling checkouts to be updated Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 126317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126317&action=edit Bug 24609: Add API unit tests Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 126318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126318&action=edit Bug 24609: Add test for timezone handling This patch adds an additional set of tests for test for how timezones are handled if we are passed an rfc3339 string with a timezone offset. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 126319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126319&action=edit Bug 24609: Add trigger to set items.onloan on due_date update This patch adds an overridden store method to Koha::Checkout to catch due_date changes and trigger an update of the items.onloan field. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 126320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126320&action=edit Bug 24609: (QA follow-up) Cleaner handling of unhandled exceptions This patch updates how we handle unhandled exceptions nowadays in Koha controllers. It also adds a missing call to ->discard_changes for the returned object. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 126321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126321&action=edit Bug 24609: (QA follow-up) Remove diag from tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please provide more tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126917&action=edit Bug 24609: Unit tests for Koha::Checkout->store This patch adds unit tests for the Koha::Item onloan trigger inside Koha::Checkout->store(); Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126316|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126921&action=edit Bug 24609: Create PUT /checkouts/{checkout_id} This patch creates a PUT /checkouts/{checkout_id} API route enabling checkouts to be updated Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126317|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126922&action=edit Bug 24609: Add API unit tests Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126318|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126923&action=edit Bug 24609: Add test for timezone handling This patch adds an additional set of tests for test for how timezones are handled if we are passed an rfc3339 string with a timezone offset. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126319|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126924&action=edit Bug 24609: Add trigger to set items.onloan on due_date update This patch adds an overridden store method to Koha::Checkout to catch due_date changes and trigger an update of the items.onloan field. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126320|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126925&action=edit Bug 24609: (QA follow-up) Cleaner handling of unhandled exceptions This patch updates how we handle unhandled exceptions nowadays in Koha controllers. It also adds a missing call to ->discard_changes for the returned object. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126321|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126926&action=edit Bug 24609: (QA follow-up) Remove diag from tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126917|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126927&action=edit Bug 24609: Unit tests for Koha::Checkout->store This patch adds unit tests for the Koha::Item onloan trigger inside Koha::Checkout->store(); Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126928&action=edit Bug 24609: WIP on api tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and added tests for the trigger introduced in Koha::Checkout->store. I've started adding some further tests to the API endpoint but came somewhat unstuck when trying to think about how readOnly and partial update requirements interact.. posted up my final work in progress patch but this is where I need a bit of input from Tomas regards expected behaviour for these cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Bug 24609 depends on bug 24850, which changed state. Bug 24850 Summary: Koha::DateUtils ignores offsets in RFC3339 datetimes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24850 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Martin, do you have plans to continue here? Afraid it doesn't apply again :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugzilla@warmlight.co.uk |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It's still on my list.. but I have other priorities at the moment.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23336 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org