http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11798 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 --- Comment #2 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Jonathan Druart from comment #1)

Are you sure it is caused by bug 12147? The patch removed "bPaginate: false,", so the pagination was already removed.

Pretty sure that it was caused by removing "bPaginate: false," (or, at least, that after re-adding it, things seem to be back to normal). I don't really know why it works that way, some DataTables weirdness maybe? My guess is that with all DataTables controls hidden with "sDom: t", pagination in still in efect "under the hood" (but no longer controllable in any way: no way to navigate to next result page or control the amount displayed). Anyway, it got me thinkig about the ergonomics of invoice search in general; maybe reenabling (at least some) datatables controls (instead of turning off "under the hood" pagination like in Bug 11798) would be way better aproach here? I mean, in mid-sized library, there may be hundreds/tousends invoices entered each year; after a relativelly short period of time this page would become less and less usable in it's current form (and also slower - but thats not easy remediable, unless we decide to convert it to ajax/server-side datatable variant ?). Apart from pagination controlls, IMO it would be nice to have a general purpose datatables search box/filter available in this page. Doing some testing right now (with sDom: "t" simply removed): - filtering by "show only subscription" does seem to coexist nicely with general-pupose DT search box (btw, having such a checkbox to show only open invoices would also be a great addition from an ergonomics standpoint) - checkboxes for selecting invoices to be merged are beahving a little weird (invoices to be merged need to be selected on the same result page for the selection to become effecive); no idea how to fix it.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 30965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30965&action=edit Bug 12646: Display all invoices on the same page Only first 20 invoices were displayed on the page. Without pagination, DT did not allow to show others. This page explicitely removes the pagination option in order to display all invoices on the page. Test plan: 1/ Create 21+ invoices 2/ Go on acqui/invoices 3/ Verify all invoices are displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12985 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.