[Bug 18574] New: Clean Patron Records tool doesn' t limit to the selected library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Bug ID: 18574 Summary: Clean Patron Records tool doesn't limit to the selected library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 63355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63355&action=edit Bug 18574 - Clean Patron Records tool doesn't limit to the selected library The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! Test Plan: 1) Note that the library pulldown on tools/cleanborrowers.pl does nothing 2) Apply this patch 3) Note that chaning the value in the pulldown now refreshed the page and sets the library correctly! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Indentation is wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63355|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 63374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63374&action=edit [SIGNED OFF] Bug 18574 - Clean Patron Records tool doesn't limit to the selected library The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! Test Plan: 1) Note that the library pulldown on tools/cleanborrowers.pl does nothing 2) Apply this patch 3) Note that chaning the value in the pulldown now refreshed the page and sets the library correctly! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed the tabs! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- QAing this now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 63378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63378&action=edit Bug 18574 - Clean Patron Records tool doesn't limit to the selected library The library selector simply does nothing because at some point the javascript that powers it was removed. This is very bad because the librarian may batch delete patrons assuming it is limiting by branch correctly and instead delete patrons for all the libraries! Test Plan: 1) Note that the library pulldown on tools/cleanborrowers.pl does nothing 2) Apply this patch 3) Note that chaning the value in the pulldown now refreshed the page and sets the library correctly! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Passed QA For reference, this bug was introduced by bug 17083 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 [Bug 17083] Remove more event attributes from tools templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63374|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05! Thanks for the quick turnaround Katrin, Julian! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org