[Bug 18560] New: RSS Feed link from OPAC shelves is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Bug ID: 18560 Summary: RSS Feed link from OPAC shelves is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |mtompset@hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 63264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63264&action=edit Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63264|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 63266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63266&action=edit Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63266|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 63286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63286&action=edit [SIGNED-OFF] Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Sure this doesn't need a signoff, but I was already signing off when Marc did! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Mark, You are not allowed to call _result outside of Koha::* Actually you do not need to retrieve the author and the title, they are both returned by GetBiblioData few lines above. And actually I do not understand this "if rss" conditional block, it looks useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63286|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 63340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63340&action=edit Bug 18560: RSS link in opac shelves is broken Removed pointless code. TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #4)
You are not allowed to call _result outside of Koha::*
Sorry, was just looking for a quick fix.
Actually you do not need to retrieve the author and the title, they are both returned by GetBiblioData few lines above.
Confirmed.
And actually I do not understand this "if rss" conditional block, it looks useless.
Patch revised accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We are a bit sparse with information in the RSS feed, for example if the entry is an article record, you would like to show the source as well. But this definitely fixes a bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 63375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63375&action=edit [SIGNED OFF] Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63340|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 63381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63381&action=edit Bug 18560: RSS link in opac shelves is broken TEST PLAN --------- 1) have books entered 2) log in create a list 3) add books to list 4) display list 5) click the RSS link button. -- bad HASH error. 6) apply patch 7) repeat steps 4&5 -- readble junk without error messages. 8) run koha qa test tools Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Simple patch, fixes the bug as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #7)
We are a bit sparse with information in the RSS feed, for example if the entry is an article record, you would like to show the source as well. But this definitely fixes a bug.
Actually, that's the other thing I did notice. RSS feeds are not consistent in what they output. This one needs improvement, but that is beyond the scope of this specific bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Attachment #63375|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org