[Bug 25763] New: Allow update of order fund after receipt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Bug ID: 25763 Summary: Allow update of order fund after receipt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: nick@bywatersolutions.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Sometimes after an order has come in there are donations or changes to funds and the library may wish to change the fund that the order is allocated from. This bug will allow updating the order fund from the invoice page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105892&action=edit Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Hi Nick ! Sorry about that, i'd be happy to test it if you can fix that one ! 105892 - Bug 25763: Allow updating of order fund from invoice Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 25763: Allow updating of order fund from invoice Using index info to reconstruct a base tree... M acqui/invoice.pl M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt Auto-merging acqui/invoice.pl Failed to merge in the changes. Patch failed at 0001 Bug 25763: Allow updating of order fund from invoice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105892|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114678&action=edit Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114678|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115368&action=edit Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, I like the idea of this! I believe the "No fund" option should be removed here. An order will always have a fund as it's mandatory and if you try to unset it (which should not be possible) you receive an error on saving. Statistic 1 and 2 should also end with a colon as form labels. The GUI looks a little bit "rough", but it's subtle, like some missing padding or maybe because the form fields are not aligned nicely with the labels? Could be something for a later patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115368|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140865&action=edit Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140866&action=edit Bug 25763: (follow-up) Fix display and remove 'No fund' This patch adds a fieldset around the inputs to style them as other places in Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #5)
Hi Nick, I like the idea of this!
I believe the "No fund" option should be removed here. An order will always have a fund as it's mandatory and if you try to unset it (which should not be possible) you receive an error on saving.
Statistic 1 and 2 should also end with a colon as form labels.
The GUI looks a little bit "rough", but it's subtle, like some missing padding or maybe because the form fields are not aligned nicely with the labels? Could be something for a later patch.
I did not remember writing this... is this that getting old thing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140865|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141546&action=edit Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140866|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141547&action=edit Bug 25763: (follow-up) Fix display and remove 'No fund' This patch adds a fieldset around the inputs to style them as other places in Koha Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31721 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like this functionality, but I'd like it better if the changes were logged. I filed bug 31721 to make a case for logging changes made to orders via the API. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |This allows to update the released in| |fund of an order line from | |the invoices page. As | |different funds might be | |linked to different | |authorized values for | |statistical purposes, the | |statistics fields can also | |be updated in the same | |step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Version(s)|This allows to update the |22.11.00 released in|fund of an order line from | |the invoices page. As | |different funds might be | |linked to different | |authorized values for | |statistical purposes, the | |statistics fields can also | |be updated in the same | |step. | Text to go in the| |This allows to update the release notes| |fund of an order line from | |the invoices page. As | |different funds might be | |linked to different | |authorized values for | |statistical purposes, the | |statistics fields can also | |be updated in the same | |step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/631 Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19192 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19192 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34444 [Bug 34444] Statistic 1/2 not saving when updating fund after receipt -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org