[Bug 33052] New: Add a message for from_local_hold_group override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Bug ID: 33052 Summary: Add a message for from_local_hold_group override Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In reference to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860#c226 from_local_hold_group needs a message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 147231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147231&action=edit Bug 33052: Add a message for from_local_hold_group override In reference to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860#c226 from_local_hold_group needs a message. Test Plan: 1) Overide a local group restricted hold, note there is no message 2) Apply this patch 3) Repeat step 1, note there is now a message! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Looking at the patch, the message seems to be: This item normally cannot be put on hold out its' local hold group. Is that right? Should it be "out of" or something like that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147231|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 153385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153385&action=edit Bug 33052: Add a message for from_local_hold_group override In reference to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860#c226 from_local_hold_group needs a message. Test Plan: 1) Overide a local group restricted hold, note there is no message 2) Apply this patch 3) Repeat step 1, note there is now a message! Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 153386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153386&action=edit Bug 33052: Fix typo Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've not used hold groups much yet, some more hints on how to quickly set them up would be helpful here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tried and failed to trigger the message: * Created a local hold group with Fairview and Fairfield * Created a record with 1 item: itemtype books, Fairfield * Added a circulation rule under all libraries with: Books - lokal holds group - any library - returns home * CircControl is: library the item is from * My user is from Centerville, I am trying to place a hod for myself in staff * I get: Cannot place hold from patron's library ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- You also need to set AllowHoldPolicyOverride to true - then you should be able to select the item and trigger an override confirmation modal displaying the message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33052 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Trying again: * Set AllowHoldPolicyOverride to Allow * Created a local hold group with Fairview and Fairfield * Created a record with 1 item: itemtype Books, Fairfield * Added a circulation rule under all libraries with: Books - local holds group - any library - returns home * CircControl is: library the item is from * My user is from Centerville, I am trying to place a hod for myself in staff * I get: Cannot place hold from patron's library ... and now I can place the hold without any error - which honestly feels not right? Please retest yourself. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org