https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 98361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98361&action=edit Bug 24573: Add missing dependencies to PerlDependencies.pm Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation The `max_ver` for Catmandu::Store::ElasticSearch is only informative and is not used anywhere. Koha is not compatible with Catmandu::Store::ElasticSearch 0.9_01 and later versions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Michal Denar from comment #3)

Hi Julian, how test this patch?

Hi, I think it's enough to `git grep Catmandu::MARC` and `git grep Catmandu::Store::ElasticSearch` to see that they are used in Koha (thus they must appear in cpanfile) But you can go further and uninstall these modules, and see that search and reindexation don't work when SearchEngine = Elasticsearch You can try the latest version of Catmandu::Store::ElasticSearch and verify that search doesn't work with it. Downgrade to 0.512 and verify that search works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98769|0 |1 is obsolete| | --- Comment #5 from Michal Denar <black23@gmail.com> --- Created attachment 99959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99959&action=edit Bug 24573: Add missing dependencies to cpanfile Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Julian Maurice from comment #4)

I think it's enough to `git grep Catmandu::MARC` and `git grep Catmandu::Store::ElasticSearch` to see that they are used in Koha (thus they must appear in cpanfile)

git grep Catmandu::MARC cpanfile:requires 'Catmandu::MARC', '1.241'; Only used in the cpanfile ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Marcel de Rooy from comment #7)

...

Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation

No, we still have Zebra. I think it should be a recommend then?

There is no rule yet for deciding when a module should be required or recommended. I think it should be required because when you turn on the feature, Koha will die if these modules are not installed, and there is nothing preventing you to turn on the feature. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Julian Maurice from comment #9)

(In reply to Marcel de Rooy from comment #7)

...

...

Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation

No, we still have Zebra. I think it should be a recommend then?

There is no rule yet for deciding when a module should be required or recommended. I think it should be required because when you turn on the feature, Koha will die if these modules are not installed, and there is nothing preventing you to turn on the feature.

It seems to be that they should not be required now, since we did not require them before in PerlDependencies. In one of the tests we are mocking the module for such a reason iirc. In Discussion? Please mail to the dev list? Or dev meeting agenda point? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99959|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 100226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100226&action=edit Bug 24573: Add missing dependencies to cpanfile When using Elasticsearch, Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100226|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 100227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100227&action=edit Bug 24573: Add missing dependencies to cpanfile When using Elasticsearch, Catmandu::Store::ElasticSearch is required for search, and Catmandu::MARC is required for indexation Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24573 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.