[Bug 24713] New: Staff interface search results page - checkbox to select records is not visible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Bug ID: 24713 Summary: Staff interface search results page - checkbox to select records is not visible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org Created attachment 99461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99461&action=edit Screenshots - Checkbox not visible in staff interface search results The checkbox for selecting records for the standard search results in the staff interface is no longer visible. Checked on latest Firefox, Chromium, and Google Chrome on Ubuntu 18.04. I've only noticed this in the last few days - it is fine in 19.11.x and at least a week ago in master. See the screenshots attached. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Component|Searching |Templates Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Git blames me and Bug 23885 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff interface search |JavaScript error on staff |results page - checkbox to |client catalog search |select records is not |results page |visible | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 99604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99604&action=edit Bug 24713: JavaScript error on staff client catalog search results page This patch modifies the output of template toolkit variables so that values in the in-page JavaScript are quoted. This avoids JavaScript errors when the template variable is empty. To test, apply the patch and perform a catalog search in the staff client. Use the browser's developer tool to check for JavaScript errors in the console. There should be none. Test with AmazonCoverImages both on and off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- QA tool reports an error which I assume is unrelated: FAIL valid_template Attempt to reload Koha/Template/Plugin/Biblio.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Plugins.pm line 206. Please correct me if I'm wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- To recreate: 1 - Set AmazonCoverImages to "Show" 2 - Set AmazonCoverImages to "Don't show" 3 - Check the DB, the pref is now "" select * from systempreferences where variable like '%amazoncover%'; 4 - Do a search on the staff client 5 - Note checkboxes are missing and there is a JS error I wonder if the problem is that we set the value for "Don't show" as "" (blank string) instead of 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate this error, however I got it yesterday and fixed it. See commit 884ab0d98e54d3a9f5229e2d21fd234dddf298b0 Bug 23777: (follow-up) Use To.json in results.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99604|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 99631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99631&action=edit Bug 24713: JavaScript error on staff client catalog search results page This patch modifies the output of template toolkit variables so that values in the in-page JavaScript are quoted. This avoids JavaScript errors when the template variable is empty. To test, apply the patch and perform a catalog search in the staff client. Use the browser's developer tool to check for JavaScript errors in the console. There should be none. Test with AmazonCoverImages both on and off. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #7 from David Nind <david@davidnind.com> --- Was just about to post - it seems that this was fixed over the last few days (one of the commits since since Saturday). I've signed it off, but feel free to close if this is not required anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- *** This bug has been marked as a duplicate of bug 23777 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
I do not recreate this error, however I got it yesterday and fixed it. See commit 884ab0d98e54d3a9f5229e2d21fd234dddf298b0 Bug 23777: (follow-up) Use To.json in results.tt
Bug 23777 has been pushed to master but this is still a problem. Reopening. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #4)
To recreate: 1 - Set AmazonCoverImages to "Show" 2 - Set AmazonCoverImages to "Don't show"
=> I get '0', and so I still do not recreate the bug. I think the patch is valid however, but I'd like to understand why it works for me. Can you confirm those steps are sufficient to recreate the problem? Which OS? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am running koha-testing-docker with KOHA_IMAGE=master with docker-compose.yml and docker-compose.mariadb_d9.yml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #11)
I am running koha-testing-docker with KOHA_IMAGE=master with docker-compose.yml and docker-compose.mariadb_d9.yml
I am using docker-compose.mariadb_d10.yml -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #12)
(In reply to Jonathan Druart from comment #11)
I am running koha-testing-docker with KOHA_IMAGE=master with docker-compose.yml and docker-compose.mariadb_d9.yml
I am using docker-compose.mariadb_d10.yml
For the record: Nick is using Debian 9 with mariaDB for Debian 10 Owen, what about you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- The question is only whether or not the value returned by the system preference check is going to trigger the error or not. If the value for AmazonCoverImages is '', the error will happen. If it's 0 or 1 it won't. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #14)
The question is only whether or not the value returned by the system preference check is going to trigger the error or not. If the value for AmazonCoverImages is '', the error will happen. If it's 0 or 1 it won't.
It's more about fixing this specific error or other possible occurrences where prefs can be an empty strings (when 0 is expected). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99631|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 100218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100218&action=edit Bug 24713: JavaScript error on staff client catalog search results page This patch modifies the output of template toolkit variables so that values in the in-page JavaScript are quoted. This avoids JavaScript errors when the template variable is empty. To test, apply the patch and perform a catalog search in the staff client. Use the browser's developer tool to check for JavaScript errors in the console. There should be none. Test with AmazonCoverImages both on and off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- git grep -l -E "parseInt\(\s*\[%" Before koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt After Nothing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #17)
git grep -l -E "parseInt\(\s*\[%" Before koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
After Nothing
You should also search for var xxx = [% Koha.Preference('xxx') %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch modifies the release notes| |output of template toolkit | |variables so that values in | |the in-page JavaScript are | |quoted. This avoids | |JavaScript errors when the | |template variable is empty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24713 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #20 from Joy Nelson <joy@bywatersolutions.com> --- does not apply to 19.11.x branch. please rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org