https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think the "lifting" works without the cronjob, just on the date. The restriction loses its effect. - The purge is for deleting them so they no longer show up in the account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think that's where we should probably look then - might be somewhere the check is not working right. But we need more details then. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #6 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 107488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107488&action=edit member entry page - restriction -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #8 from Kelly McElligott <kelly@bywatersolutions.com> --- Yes - greyed out would be good! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26728 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding more details to the |Add styling to show expired |manual about Patron |patron restrictions as |Restrictions |inactive Component|Patrons |Documentation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 156026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156026&action=edit Bug 26053: Distinguish expired patron restrictions On the patron detail page, in restrictions table to show that the restriction has expired. With text and a grey color line. Uses 'text-muted' boostrap class (already used in OPAC). Test plan : 1) Go to a patron details page cgi-bin/koha/members/moremember.pl 2) Create 2 restrictions in the future 3) Edit in database to se the first restriction into the past 4) Create a retriction without date 5) Check you see on expired line text : (expired) 6) Check line is grey -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Testing comments - I wasn't sure if I had to rebuild yarn after applying the patch. I did it anyway since it doesn't hurt anything if it wasn't necessary - To edit the restriction in the database, it's in the borrower_debarments tables (I couldn't remember and had to search for it). I did select * from borrower_debarments where borrowernumber = 49; Then chose one of the id's to edit update borrower_debarments set expiration = '2023-08-23', created = '2023-08-12 09:46:37' where borrower_debarment_id = 25; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #16 from David Nind <david@davidnind.com> --- One thing I noticed was that when clicking on the 'View restrictions' button (on either the check out or details tab): - It opens the Restrictions tab - But doesn't move you down the page to the actual tab It's not related to this bug, so I can create another bug for this if this is happening for others as well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #18 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to David Nind from comment #17)

For some reason, I didn't notice that it had already been signed off!

Bug 34891 created.

No worries, two pairs of eyes is always better than one! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 156424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156424&action=edit Bug 26053: Add unit test for Koha::Patron::Restriction Run: prove t/db_dependent/Koha/Patron/Restriction.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156424|0 |1 is obsolete| | --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 156426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156426&action=edit Bug 26053: Add unit test for Koha::Patron::Restriction Run: prove t/db_dependent/Koha/Patron/Restriction.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah I found there is a "expired" CSS class already used by additional contents : https://git.koha-community.org/Koha-community/Koha/src/commit/d9849aaa3aa777... So I change to use it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156425|0 |1 is obsolete| | --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 156427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156427&action=edit Bug 26053: Distinguish expired patron restrictions On the patron detail page, in restrictions table to show that the restriction has expired. With text and a grey color line. Uses 'text-muted' boostrap class (already used in OPAC). Test plan : 1) Go to a patron details page cgi-bin/koha/members/moremember.pl 2) Create 2 restrictions in the future 3) Edit in database to se the first restriction into the past 4) Create a retriction without date 5) Check you see on expired line text : (expired) 6) Check line is grey -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #29 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> ---

Also UT helped me to find an issue with expiration = today, one must use day truncation like in Koha::Patron : dt_from_string->truncate( to => 'day' );

Hmmm, it looks like Koha::Patron is inconsistent with itself in that. $patron->is_expired uses: return 1 if dt_from_string( $self->dateexpiry ) < dt_from_string->truncate( to => 'day' ); $patron->password_expired uses: return 1 if dt_from_string( $self->password_expiration_date ) <= dt_from_string->truncate( to => 'day' ); $patron->is_debarred uses: return $self->debarred if $self->debarred =~ '^9999' or dt_from_string( $self->debarred ) > dt_from_string; We should probably standardize those on another bug... I don't think we should be truncating just one, though. Then if the expiration date == today, we're comparing, for instance, '2023-09-29 00:00:00' to '2023-09-29', which should be equal, but won't evaluate to equal. We should truncate either both or neither. In any case, in this particular situation, the behavior should match the behavior of $patron->is_debarred, since we're looking at restrictions. If the restriction's expiration date is today, it would compare: '2023-09-29 00:00:00' > '2023-09-29 09:31:23' (or whatever the current time is), which would return false (the patron is not debarred), which means the restriction IS expired. I don't see a coding guideline about whether to truncate or not, so I think that's up to you. To make the behavior consistent with is_debarred, it would need to be either: dt_from_string( $self->expiration ) < dt_from_string or if dt_from_string( $self->expiration )->truncate( to => 'day' ) <= dt_from_string->truncate( to => 'day' ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156427|0 |1 is obsolete| | --- Comment #31 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 156725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156725&action=edit Bug 26053: Distinguish expired patron restrictions On the patron detail page, in restrictions table to show that the restriction has expired. With text and a grey color line. Uses 'text-muted' boostrap class (already used in OPAC). Test plan : 1) Go to a patron details page cgi-bin/koha/members/moremember.pl 2) Create 2 restrictions in the future 3) Edit in database to se the first restriction into the past 4) Create a retriction without date 5) Check you see on expired line text : (expired) 6) Check line is grey -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156725|0 |1 is obsolete| | --- Comment #33 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 156727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156727&action=edit Bug 26053: Distinguish expired patron restrictions On the patron detail page, in restrictions table to show that the restriction has expired. With text and a grey color line. Uses 'text-muted' boostrap class (already used in OPAC). Test plan : 1) Go to a patron details page cgi-bin/koha/members/moremember.pl 2) Create 2 restrictions in the future 3) Edit in database to se the first restriction into the past 4) Create a retriction without date 5) Check you see on expired line text : (expired) 6) Check line is grey -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #35 from Fridolin Somers <fridolin.somers@biblibre.com> --- To be super clear I added a comment and variable : + # This condition must be consistent with Koha::Patron->is_debarred + my $makes_patron_debarred = dt_from_string( $self->expiration ) > dt_from_string; + return 1 unless $makes_patron_debarred; -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156727|0 |1 is obsolete| | --- Comment #36 from David Nind <david@davidnind.com> --- Created attachment 156757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156757&action=edit Bug 26053: Distinguish expired patron restrictions On the patron detail page, in restrictions table to show that the restriction has expired. With text and a grey color line. Uses 'text-muted' boostrap class (already used in OPAC). Test plan : 1) Go to a patron details page cgi-bin/koha/members/moremember.pl 2) Create 2 restrictions in the future 3) Edit in database to se the first restriction into the past 4) Create a retriction without date 5) Check you see on expired line text : (expired) 6) Check line is grey Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement highlights release notes| |that a patron restriction | |is expired in the patron | |restriction table (Patrons | |> ([patron] > Check out or | |Details tab > | |Restrictions): | |- adds the | |text "(expired)" after the | |expiration date, and | |- | |changes the text color for | |the line to a light gray. --- Comment #38 from David Nind <david@davidnind.com> --- Note for documentation updates: 1. The change in this bug needs to be incorporated. 2. Add a note (if it doesn't exist already) about the cron job (misc/cronjobs/cleanup_database.pl) that needs to be run to remove expired restrictions. (see #c1) 3. Update the cron job (misc/cronjobs/cleanup_database.pl) information if any updates are required. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156757|0 |1 is obsolete| | --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156762&action=edit Bug 26053: Distinguish expired patron restrictions On the patron detail page, in restrictions table to show that the restriction has expired. With text and a grey color line. Uses 'text-muted' boostrap class (already used in OPAC). Test plan : 1) Go to a patron details page cgi-bin/koha/members/moremember.pl 2) Create 2 restrictions in the future 3) Edit in database to se the first restriction into the past 4) Create a retriction without date 5) Check you see on expired line text : (expired) 6) Check line is grey Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.