[Bug 34873] New: "Sending your cart/list" headings are inconsistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Bug ID: 34873 Summary: "Sending your cart/list" headings are inconsistent Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The heading on the "Send list" pop-up in the staff interface is a h1 that appears quite big within the fieldset, while the "send cart" uses a legend, that appears in a nicer way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156377&action=edit Bug 34873: Fix inconsistencies between "Sending your cart/list" headings This patch modifies the templates for the popup windows which are shown when you send a cart or a list via email in the staff interface. To test, apply the patch and log into the staff interface. - Perform a catalog search which will return results. - Select one or more results and add them to the cart. - Click the cart icon in the header menu to open the Cart popup. - Click "Send". Compare this pop-up window to the version shown when sending a list: - Open the Lists page and view the contents of a list. - Click the "Send list" button in the toolbar. - This popup should look correct and be consistent with the Cart version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156377|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 156449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156449&action=edit Bug 34873: Fix inconsistencies between "Sending your cart/list" headings This patch modifies the templates for the popup windows which are shown when you send a cart or a list via email in the staff interface. To test, apply the patch and log into the staff interface. - Perform a catalog search which will return results. - Select one or more results and add them to the cart. - Click the cart icon in the header menu to open the Cart popup. - Click "Send". Compare this pop-up window to the version shown when sending a list: - Open the Lists page and view the contents of a list. - Click the "Send list" button in the toolbar. - This popup should look correct and be consistent with the Cart version. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 156450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156450&action=edit Screenshot - Send cart and lists pop-up windows I've signed off as they now look much more consistent! However, I did note that for the cart there is a more space before the heading than with the list (see attached image). My CSS is not that great, but maybe this is something to do with the div for the container. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156449|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156678&action=edit Bug 34873: Fix inconsistencies between "Sending your cart/list" headings This patch modifies the templates for the popup windows which are shown when you send a cart or a list via email in the staff interface. To test, apply the patch and log into the staff interface. - Perform a catalog search which will return results. - Select one or more results and add them to the cart. - Click the cart icon in the header menu to open the Cart popup. - Click "Send". Compare this pop-up window to the version shown when sending a list: - Open the Lists page and view the contents of a list. - Click the "Send list" button in the toolbar. - This popup should look correct and be consistent with the Cart version. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34873 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- As far as I can see, this doesn't change anything for the manual. Feel free to reopen with more details if I'm wrong. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org