[Bug 41044] New: Fix argument isn't numeric in addition in Koha::Item::find_booking
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Bug ID: 41044 Summary: Fix argument isn't numeric in addition in Koha::Item::find_booking Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 188064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188064&action=edit Bug 41044: Add a failing test To test: 1. prove t/db_dependent/Koha/Item.t 2. Observe failing test Subtest: test empty string warning 1..1 not ok 1 - No warnings were produced Failed test 'No warnings were produced' at t/db_dependent/Koha/Item.t line 3656. found warning: Argument "" isn't numeric in addition (+) at /usr/local/lib/x86_64-linux-gnu/perl/5.34.0/DateTime/Duration.pm line 70. didn't expect to find a warning Looks like you failed 1 test of 1. not ok 9 - test empty string warning Failed test 'test empty string warning' at t/db_dependent/Koha/Item.t line 3657. Looks like you failed 1 test of 9. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 188065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188065&action=edit Bug 41044: Fix warning To test: 1. prove t/db_dependent/Koha/Item.t 2. Observe success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I'm not getting any test failures on the current main and latest KTD. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188064|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 188447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188447&action=edit Bug 41044: Add a failing test To test: 1. prove t/db_dependent/Koha/Item.t 2. Observe failing test Subtest: test empty string warning 1..1 not ok 1 - No warnings were produced Failed test 'No warnings were produced' at t/db_dependent/Koha/Item.t line 3656. found warning: Argument "" isn't numeric in addition (+) at /usr/local/lib/x86_64-linux-gnu/perl/5.34.0/DateTime/Duration.pm line 70. didn't expect to find a warning Looks like you failed 1 test of 1. not ok 9 - test empty string warning Failed test 'test empty string warning' at t/db_dependent/Koha/Item.t line 3657. Looks like you failed 1 test of 9. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188065|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 188448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188448&action=edit Bug 41044: Fix warning To test: 1. prove t/db_dependent/Koha/Item.t 2. Observe success Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #3)
I'm not getting any test failures on the current main and latest KTD.
Please ignore, I didn't test correctly! Testing notes (using KTD): 1. Apply the first patch - tests should fail. 2. Apply the second patch - test now pass! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188447|0 |1 is obsolete| | --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188826&action=edit Bug 41044: Add a failing test To test: 1. prove t/db_dependent/Koha/Item.t 2. Observe failing test Subtest: test empty string warning 1..1 not ok 1 - No warnings were produced Failed test 'No warnings were produced' at t/db_dependent/Koha/Item.t line 3656. found warning: Argument "" isn't numeric in addition (+) at /usr/local/lib/x86_64-linux-gnu/perl/5.34.0/DateTime/Duration.pm line 70. didn't expect to find a warning Looks like you failed 1 test of 1. not ok 9 - test empty string warning Failed test 'test empty string warning' at t/db_dependent/Koha/Item.t line 3657. Looks like you failed 1 test of 9. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188448|0 |1 is obsolete| | --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 188827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188827&action=edit Bug 41044: Fix warning To test: 1. prove t/db_dependent/Koha/Item.t 2. Observe success Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |paul.derscheid@lmscloud.de |y.org | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.06 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41044 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind <david@davidnind.com> --- Bug fixs, no changes require to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org