[Bug 41092] New: Some system preferences have target='blank' instead of target='_blank'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Bug ID: 41092 Summary: Some system preferences have target='blank' instead of target='_blank' Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I found this while translating and I've never seen target='blank' before, I've only ever seen target='_blank' (with the underscore). koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref: - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/items.html' target='blank'>database columns</a> should be unique in an item:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> must be filled in on the patron modification screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> must be filled in on the patron entry screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron self-registration screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref: - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron self-modification screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: - "Valid options are the <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> of the borrowers table, separated by | (pipe)." koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> must be filled in on the patron entry screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a> will not appear on the patron entry screen:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a>:" koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref: - "The following <a href='https://schema.koha-community.org/__VERSION__/tables/borrowers.html' target='blank'>database columns</a>:" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 188393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188393&action=edit Bug 41092: Some system preferences have target='blank' instead of target='_blank' This patch changes target='blank' to target='_blank' in system preferences. To test: 1. Apply the patch 2. Check the following system preferences, click on the links, make sure every click opens in a new tab - UniqueItemFields - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - EmailFieldPrecedence - BorrowerMandatoryField - BorrowerUnwantedField - PatronQuickAddFields - PatronDuplicateMatchingAddFields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- For reference, Paul D. sent me this stack overflow answer regarding the difference between blank and _blank. One will open all the clicks in the same tab (it will open a new tab the first time, but then identify that tab as "blank" and open all further clicks in that same one), whereas _blank will open always in a new tab. (... Is how I understand it!) https://stackoverflow.com/questions/36769460/is-the-underscore-in-target-bla... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Good catch. I recently noticed this somewhere in Koha as well I think... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188393|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188413&action=edit Bug 41092: Some system preferences have target='blank' instead of target='_blank' This patch changes target='blank' to target='_blank' in system preferences. To test: 1. Apply the patch 2. Check the following system preferences, click on the links, make sure every click opens in a new tab - UniqueItemFields - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - EmailFieldPrecedence - BorrowerMandatoryField - BorrowerUnwantedField - PatronQuickAddFields - PatronDuplicateMatchingAddFields Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188413|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 188436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188436&action=edit Bug 41092: Some system preferences have target='blank' instead of target='_blank' This patch changes target='blank' to target='_blank' in system preferences. To test: 1. Apply the patch 2. Check the following system preferences, click on the links, make sure every click opens in a new tab - UniqueItemFields - PatronSelfModificationMandatoryField - PatronSelfRegistrationBorrowerMandatoryField - PatronSelfRegistrationBorrowerUnwantedField - PatronSelfModificationBorrowerUnwantedField - EmailFieldPrecedence - BorrowerMandatoryField - BorrowerUnwantedField - PatronQuickAddFields - PatronDuplicateMatchingAddFields Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Text to go in the| |This fixes the HTML target release notes| |attribute for some system | |preference links that open | |a pop-up window or external | |link. The link attribute | |now uses "_blank" instead | |of "blank", and opens in a | |new tab for external links, | |and the same browser window | |for pop-up windows | |(modals). CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Have changed to a minor bug, instead of an enhancement. QA script is happy. One thing I noticed, is that when you press "Save" for any changes in the pop-up windows, you get the notification "Saved preference XXXXX", but the "Save all XXX preferences" button in orange is still highlighted. Clicking that says "nothing to save". Outside the scope of this bug to fix that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- According to Bugzilla no one wrote this patch and no one QA'd it? Fill out the Assignee and QA Contact fields please. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | --- Comment #8 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass (lukeg) from comment #7)
According to Bugzilla no one wrote this patch and no one QA'd it?
Fill out the Assignee and QA Contact fields please.
Fields updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41092 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org