[Bug 6125] New: Plugin for date acquired does not work on ACQ framework
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 Bug #: 6125 Summary: Plugin for date acquired does not work on ACQ framework Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All URL: /cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&ba sketno=2# OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org It does not work because the plugin dateaccessioned is wrong. dateaccessioned relies on a javascript sub (set_to_today) that is defined in additem.pl. For acquisition (and serials), the set_to_today is not defined. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6106 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 22:55:11 UTC --- The plugin is still broken in current master/version 3.6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still a bug in current master. The plugin for accession date does not work, neither in ACQ nor in the Default framework. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adrien.saurat@biblibre.com Assignee|henridamien@koha-fr.org |adrien.saurat@biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 --- Comment #3 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8347&action=edit proposed patch #1 Repairs dateaccessioned plugin 1/ It now works with neworderempty.pl 2/ The set_to_today function was moved from additem.tt to dateaccessioned.pl (so it's available to all pages using the plugin) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 Julien Sicot <julien.sicot@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julien.sicot@gmail.com --- Comment #4 from Julien Sicot <julien.sicot@gmail.com> --- Hi, I applied the patch and it works well. Tested in placing order, in receiving order and in cataloging (attach/edit items), everything is OK. Tested on sandbox. Julien -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal@gmail.com --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> --- Moves set_to_today from template to script, and that seems fine. There are now some hardcoded English strings for the error messaging, though... obviously not ideal, but is it a big enough to require a followup? As an English speaker, I don't feel like I can answer this. Will someone in a non-English context please advise me on this? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure how a user can make this alerts show - if it's more for debugging than for the end user I think having them in the .pl may be fine for now and it could be improved with a follow up later on. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <koha.sekjal@gmail.com> --- Alright, that sounds fair. Marking Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 --- Comment #8 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Oh, indeed, that's a JS code but included in a pl file, and thus not translated... As Katrin said, it's not aimed at end user and this message was probably never displayed. Maybe it could have been removed in fact (replaced with something like "If ID exists then do something Else do nothing"). But well, could be useful one day =) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6125 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org