http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 --- Comment #2 from Serhij Dubyk <dubyk@library.lviv.ua> 2011-05-31 11:01:47 UTC --- I want to upgrade most sql-files for Ukrainian and Russian localizations. Process of submitting the patch is stopped at the next step: git send-email -to koha-patches@lists.koha-community.org kohaclone/0001-Many-changes-for-Ukrainian-and-Russian-sql.patch fatal: kohaclone/0001-Many-changes-for-Ukrainian-and-Russian-sql.patch: 1730: patch contains a line longer than 998 characters warning: no patches were sent I shortened the length of lines in some files but it still does not help. This sql-tables was adapted for Koha 3.2.x and now for Koha 3.4.1. System prefs synchonized with [koha.git]/installer/data/mysql/en/mandatory/sysprefs.sql few days ago. Please commit this patch. Thanks! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-05-31 16:17:54 UTC --- Your patch doesn't apply on HEAD. INSERT INTO authorised_values (category, authorised_value, lib) VALUES error: patch failed: installer/data/mysql/ru-RU/optional/patron_atributes.sql:1 error: installer/data/mysql/ru-RU/optional/patron_atributes.sql: patch does not apply error: patch failed: installer/data/mysql/uk-UA/optional/patron_atributes.sql:1 error: installer/data/mysql/uk-UA/optional/patron_atributes.sql: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. Cannot fall back to three-way merge. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 --- Comment #5 from Serhij Dubyk <dubyk@library.lviv.ua> 2011-06-21 07:07:40 UTC --- Maybe this patch should be divided into many small? With the help "git send-email" I can't do next changes in sql-tables: 1) Delete old tables uk-UA / mandatory / system_preferences_full_optimal_for_install_only.sql uk-UA / mandatory / system_preferences_only_translation_updating.sql uk-UA / mandatory / system_preferences_optimal_values_insert_only.sql ru-RU / mandatory / system_preferences_full_optimal_for_install_only.sql ru-RU / mandatory / system_preferences_only_translation_updating.sql ru-RU / mandatory / system_preferences_optimal_values_insert_only.sql and replace them by new ones https://www.dropbox.com/s/f07d6nidu39mvdj/uk-UA/mandatory/system_preferences... https://www.dropbox.com/s/f07d6nidu39mvdj/ru-RU/mandatory/system_preferences... 2) Replace old uk-UA / mandatory / sample_notices.sql ru-RU / mandatory / sample_notices.sql with new https://www.dropbox.com/s/f07d6nidu39mvdj/ru-RU/mandatory/sample_notices.sql https://www.dropbox.com/s/f07d6nidu39mvdj/uk-UA/mandatory/sample_notices.sql 3) maybe some other sql-tables - I do not know how to see all files that are not suitable for "git send-email" Other sql-tables I can send with many small patches - if this makes sense? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 --- Comment #7 from Frédéric Demians <frederic@tamil.fr> ---

I try to split this patch into smaller pieces and include them here ...

If you can't, just sent me the file by email. I will push it on a git repository as a branch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 --- Comment #9 from Serhij Dubyk <dubyk@library.lviv.ua> --- Created attachment 8722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8722&action=edit Bug 6434 - Ukrainian and Russian MARC sql-tables Changes: Marc21 support, 995 for items (Unimarc), authorities types for both MARC's, many small field/subfield changes -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- Serhij, could say more about what your patch is supposed to do? Why is there two patches attached and not one? (it seems to be the same). Mark as obsolete one of them if necessary. The first patch is non manageable. If it is a bzip2 compressed patch, attach it as you have done for the second patch. I've been able bunzip2 the second patch which delete deprecated Ukrainian and Russian SQL tables but I can't see any new tables. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 Serhij Dubyk <dubyk@library.lviv.ua> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8721|0 |1 is obsolete| | Attachment #8722|0 |1 is obsolete| | --- Comment #12 from Serhij Dubyk <dubyk@library.lviv.ua> --- Created attachment 8728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8728&action=edit Bug 6434 - Ukrainian and Russian MARC sql-tables Changes: Marc21 support, 995 for items (Unimarc), authorities types for both MARC's, many small field/subfield changes -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #15 from Ian Walls <koha.sekjal@gmail.com> --- The compressed, signed-off patch only affects SQL files (and their related txt descriptions) in ru-RU and uk-UA. Given the size, and that I'm unfamiliar with Cyrillic, I haven't read the complete patch, but I did a scan for unintended side effects to the database (a limited one), and didn't find any adverse issues. This is a huge patch, decompressed, and would greatly increase Koha's overall size. Our choice, then, is whether to accept this size increase to the repo, forever, or to implement a splitting/shrinking plan and accept the consequences thereof. I would recommend input from as many community members as possible here, both developers and those using non-English translations of Koha. I'm loathe to lose any history from the repo, as it makes my job as a developer harder, but increasing the overall disk space requirement for Koha doesn't do users any favours. I'm not sure I have good advice on how to proceed.

From a purely technical standpoint, this file looks safe, and can Pass QA. As to exactly how it's contents are added to Koha, however, may require some additional discussion.

Marking as Passed QA, but with the recommendation that we discuss how to apply this before it's pushed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 --- Comment #16 from Serhij Dubyk <dubyk@library.lviv.ua> --- Work on these tables in partly sponsored by the libraries: LTS Library(http://koha.lts.lviv.ua:8008/,Unimarc), TNTU Scintific Technical Library(http://koha.tntu.edu.ua/,Unimarc), DCU Library (http://109.254.48.77:8008/,Unimarc), Dmitry Pozharsky University Library (http://lib.s-and-e.ru/,Marc21) and ServanTek Company (http://servantek.org.ua/). I not so frequently updating these MARC-sql-table, so there are so many changes. Old tables deleted in this patch (add ~ 2 Mb to patch). To facilitate further support all tables converted as follows: 1) separated standard MARC fields/subfields and specific for Koha 2) reformated all sql as follow (collected the appropriate fields/subfields and aligned): INSERT INTO marc_tag_structure (frameworkcode, tagfield, mandatory, repeatable, liblibrarian, libopac, authorised_value) VALUE ('', '011', '', 1, 'Міжнародний стандартний номер серіального видання (ISSN)', 'ISSN', ''); INSERT INTO marc_subfield_structure (frameworkcode, authtypecode, tagfield, tagsubfield, mandatory, repeatable, liblibrarian, ('', '', '011', 'a', 0, 0, 'Номер (ISSN)', 'ISSN', 0, NULL, 'biblioitems.issn', '', '', NULL, NULL, NULL, ('', '', '011', 'b', 0, 0, 'Уточнення', '', -1, NULL, '', '', '', NULL, NULL, NULL, NULL), ('', '', '011', 'd', 0, 0, 'Умови придбання і/або ціна', '', -1, NULL, '', '', '', NULL, NULL, NULL, NULL), ('', '', '011', 'y', 0, 0, 'Анульований ISSN', '', -1, NULL, '', '', '', NULL, NULL, NULL, NULL), ('', '', '011', 'z', 0, 0, 'Помилковий ISSN', '', -1, NULL, '', '', '', NULL, NULL, NULL, NULL); - for easier reading/editing by human. In result, the size of the tables corresponding to the size of other languages from /data/mysql/ ​​(including the fact that that the Cyrillic characters are 2 bytes). P.S. Also, I have scripts that perform such reformatting as above and the initial script, which compares the fields/subfields for all languages ​​from Koha-sql. If someone is interested, I unload them somewhere publicly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6434 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.