[Bug 10453] New: updating child to adult loses password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Bug ID: 10453 Summary: updating child to adult loses password Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Tested in 3.10.x and master. When you update a child to an adult it loses the password (or changes it) - the patron can no longer log in to the OPAC after using the 'update child to adult' in the staff client. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23809&action=edit Bug 10453: Updating child to adult loses password ModMember supposes the password given in parameter is the password string, so if it receives the encrypted password, it will encrypt it again! Test plan: 1/ Create or choose a child patron 2/ Update it to an adult category using the "Update child to adult patron" link 3/ Try to log in at the OPAC with this patron: It is not possible, the password has changed 4/ Apply the patch and try again previous steps -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 23810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23810&action=edit [SIGNED OFF] Bug 10453: Updating child to adult loses password ModMember supposes the password given in parameter is the password string, so if it receives the encrypted password, it will encrypt it again! By simply deleting the password key from the hash, ModMember leaves the password unchanged. Test plan: 1/ Create or choose a child patron 2/ Update it to an adult category using the "Update child to adult patron" link 3/ Try to log in at the OPAC with this patron: It is not possible, the password has changed 4/ Apply the patch and try again previous steps Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23809|0 |1 is obsolete| | CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Merry Christmas! :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23810|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23818&action=edit [PASSED QA] Bug 10453: Updating child to adult loses password ModMember supposes the password given in parameter is the password string, so if it receives the encrypted password, it will encrypt it again! By simply deleting the password key from the hash, ModMember leaves the password unchanged. Test plan: 1/ Create or choose a child patron 2/ Update it to an adult category using the "Update child to adult patron" link 3/ Try to log in at the OPAC with this patron: It is not possible, the password has changed 4/ Apply the patch and try again previous steps Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Confirmed the problem and tested the patch fixes it. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.11. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org