[Bug 11412] New: Bulkmarcimport can crash when searching for duplicates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Bug ID: 11412 Summary: Bulkmarcimport can crash when searching for duplicates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org bulkmarcimport.pl can crash when searching for duplicates if the 005 field from the incoming or local record is not defined. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 23620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23620&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23620|0 |1 is obsolete| | --- Comment #2 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 23621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23621&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23621|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23754&action=edit Bug 11412: Bulkmarcimport can crash when searching for duplicates in authorities bulkmarcimport.pl can crash when searching for duplicates if the 005 field from the incoming or local record is not defined. This patch fixes it. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Test plan 1/ Create a record with no 005 field 2/ Try to import it checking for duplicates, notice it crashes 3/ Try with a record with a 005 field, but the one in Koha missing one, still crashes 4/ Apply patch 5/ No more crash -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |matthias.meusburger@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23754|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23819&action=edit [PASSED QA] Bug 11412: Bulkmarcimport can crash when searching for duplicates in authorities bulkmarcimport.pl can crash when searching for duplicates if the 005 field from the incoming or local record is not defined. This patch fixes it. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Test plan 1/ Create a record with no 005 field 2/ Try to import it checking for duplicates, notice it crashes 3/ Try with a record with a 005 field, but the one in Koha missing one, still crashes 4/ Apply patch 5/ No more crash Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Patch fixes the problem described for importing authorities with the bulkmarcimport.pl when trying to match with existing records. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- And a special thanks to Galen for http://galencharlton.com/blog/2013/10/introducing-the-next-new-marc-editor-v... :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Matthias! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.11. Thanks Matthias! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org